Skip to content

src: use make_shared for safe allocation - #37139

Merged
Trott merged 1 commit into
nodejs:masterfrom
yashLadha:fix_reduce_allocation
Feb 6, 2021
Merged

src: use make_shared for safe allocation#37139
Trott merged 1 commit into
nodejs:masterfrom
yashLadha:fix_reduce_allocation

Conversation

@yashLadha

@yashLadhayashLadha commented Jan 30, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 30, 2021
@nodejs-github-bot

nodejs-github-bot commented Feb 1, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35850/

@yashLadha

yashLadha commented Feb 6, 2021

Copy link
Copy Markdown
ContributorAuthor

Can I go ahead and deploy @addaleax@jasnell@cjihrig?

@Trott
Trottforce-pushed the fix_reduce_allocation branch from 0c80e8c to f3381a2CompareFebruary 6, 2021 17:02
@yashLadha@Trott
src: use make_shared for safe allocation
36cc0ee
Using the reset does a double allocation and is error prone if some
exception occured which is very unlikely but can happen. make_shared_ptr
gives hedge over this and handle the failure in allocation.
PR-URL: nodejs#37139
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Trottforce-pushed the fix_reduce_allocation branch from f3381a2 to 36cc0eeCompareFebruary 6, 2021 17:03
@Trott
Trott merged commit 36cc0ee into nodejs:masterFeb 6, 2021
@Trott

Trott commented Feb 6, 2021

Copy link
Copy Markdown
Member

Landed in 36cc0ee

danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@yashLadha@danielleadams
src: use make_shared for safe allocation
354df9e
Using the reset does a double allocation and is error prone if some
exception occured which is very unlikely but can happen. make_shared_ptr
gives hedge over this and handle the failure in allocation.
PR-URL: #37139
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Feb 16, 2021
Closed
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@yashLadha@targos
src: use make_shared for safe allocation
88d9676
Using the reset does a double allocation and is error prone if some
exception occured which is very unlikely but can happen. make_shared_ptr
gives hedge over this and handle the failure in allocation.
PR-URL: #37139
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yashLadha@nodejs-github-bot@Trott@jasnell@addaleax@cjihrig