Uh oh!
There was an error while loading. Please reload this page.
[v12.x backport] worker: add eventLoopUtilization() - #37165
Merged
richardlau merged 2 commits intoMar 16, 2021
Conversation
juanarbolforce-pushed
the
backport-35664-to-12.x
branch
from
February 1, 2021 03:34
5bbaeb0 to
542c56fComparenodejs-github-bot
commented
Feb 1, 2021
Collaborator
jasnell
approved these changes
Feb 1, 2021
nodejs-github-bot
commented
Feb 1, 2021
Collaborator
richardlau
commented
Feb 1, 2021
Member
Does this include #35891? |
juanarbol
commented
Feb 1, 2021
MemberAuthor
Nope, let me work on that for both backport PRs |
juanarbol
commented
Feb 1, 2021
MemberAuthor
@richardlau should I squash #35891 with #35664 ? or basically follow the steps described in the backporting guide (here) for both commits ? |
juanarbol
commented
Feb 1, 2021
MemberAuthor
The |
nodejs-github-bot
commented
Feb 1, 2021
Collaborator
ruyadornoforce-pushed
the
v12.x-staging
branch
from
February 10, 2021 03:16
97183ae to
4ac8f37Comparejuanarbolforce-pushed
the
backport-35664-to-12.x
branch
from
February 10, 2021 21:49
344f7ff to
e132479Comparejuanarbol
commented
Feb 22, 2021
MemberAuthor
@richardlau is there anything missing here? |
richardlauforce-pushed
the
v12.x-staging
branch
from
February 23, 2021 12:51
0692611 to
6cef0e3Compare
This comment has been minimized.
This comment has been minimized.
richardlau
commented
Mar 2, 2021
Member
@juanarbol Could you rebase this onto the current v12.x-staging please? |
juanarbolforce-pushed
the
backport-35664-to-12.x
branch
from
March 2, 2021 20:23
e132479 to
77ef942Comparejuanarbolforce-pushed
the
backport-35664-to-12.x
branch
from
March 2, 2021 20:25
77ef942 to
2e3251eComparejuanarbol
commented
Mar 2, 2021
MemberAuthor
@richardlau Rebased! |
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Mar 2, 2021
Collaborator
nodejs-github-bot
commented
Mar 7, 2021
Collaborator
richardlau
commented
Mar 8, 2021
Member
@juanarbol |
juanarbolforce-pushed
the
backport-35664-to-12.x
branch
from
March 8, 2021 20:38
2e3251e to
e663156Comparejuanarbolforce-pushed
the
backport-35664-to-12.x
branch
from
March 8, 2021 21:14
e663156 to
280d3c2Comparenodejs-github-bot
commented
Mar 9, 2021
Collaborator
juanarbol
commented
Mar 9, 2021
MemberAuthor
@richardlau, your review is addressed :) I think this is ready to be landed. |
richardlau
approved these changes
Mar 16, 2021
Allow calling eventLoopUtilization() directly on a worker thread:
const worker = new Worker('./foo.js');
const elu = worker.performance.eventLoopUtilization();
setTimeout(() => {
worker.performance.eventLoopUtilization(elu);
}, 10);
Add a new performance object on the Worker instance that will hopefully
one day hold all the other performance metrics, such as nodeTiming.
Include benchmarks and tests.
PR-URL: nodejs#35664
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Backport-PR-URL: nodejs#37165The active worker check compared the time from sending message till response arrived from worker with the complete time the worker was running till it responses to the spin request. If sending back the message is slow for some reason the test fails. Adapt the test to compare the time seen inside the worker with the time read from main thread. PR-URL: nodejs#35891Fixes: nodejs#35844 Refs: nodejs#35886 Refs: nodejs#35664 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: nodejs#37165
richardlauforce-pushed
the
backport-35664-to-12.x
branch
from
March 16, 2021 00:22
280d3c2 to
d7a4ccdComparerichardlau
commented
Mar 16, 2021
Member
Landed in 0f6d445...d7a4ccd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #35664
Allow calling eventLoopUtilization() directly on a worker thread:
Add a new performance object on the Worker instance that will hopefully
one day hold all the other performance metrics, such as nodeTiming.
Include benchmarks and tests.
PR-URL: #35664
Reviewed-By: Juan José Arboleda soyjuanarbol@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Gerhard Stöbich deb2001-github@yahoo.de
Reviewed-By: James M Snell jasnell@gmail.com