Skip to content

deps: upgrade npm to 7.5.2 - #37191

Closed
ruyadorno wants to merge 1 commit into
nodejs:masterfrom
npm:npm-7.5.2
Closed

deps: upgrade npm to 7.5.2#37191
ruyadorno wants to merge 1 commit into
nodejs:masterfrom
npm:npm-7.5.2

Conversation

@ruyadorno

@ruyadornoruyadorno commented Feb 2, 2021

Copy link
Copy Markdown
Member

v7.5.2 (2021-02-02)

BUG FIXES

DEPENDENCIES

@nodejs-github-botnodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Feb 2, 2021
@nodejs-github-bot

nodejs-github-bot commented Feb 2, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35896/

@bricssbricss mentioned this pull request Feb 2, 2021
Merged
@targos

targos commented Feb 2, 2021

Copy link
Copy Markdown
Member

@ruyadorno should I postpone #37183 to tomorrow to include this?

@ruyadorno

ruyadorno commented Feb 2, 2021

Copy link
Copy Markdown
MemberAuthor

it would be nice to have, since there are some important npx and npm init related bug fixes - that said I don't want to give you extra work @targos and I also think it's ok to wait to land these in the next release cycle 😅

@ruyadorno

ruyadorno commented Feb 2, 2021

Copy link
Copy Markdown
MemberAuthor

also, just synced with the rest of the team and the consensus is that there's no need to postpone!

MylesBorins
MylesBorins approved these changes Feb 2, 2021
View reviewed changes

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Trott
Trott approved these changes Feb 2, 2021
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@nodejs-github-bot

nodejs-github-bot commented Feb 2, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35904/

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 2, 2021
@nodejs-github-bot

nodejs-github-bot commented Feb 2, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35907/

@MylesBorins

MylesBorins commented Feb 3, 2021

Copy link
Copy Markdown
Contributor

fast track?

@MylesBorinsMylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 3, 2021
@Trott

Trott commented Feb 3, 2021

Copy link
Copy Markdown
Member

Landed in 861a396

@TrottTrott closed this Feb 3, 2021
Trott pushed a commit that referenced this pull request Feb 3, 2021
@ruyadorno@Trott
deps: upgrade npm to 7.5.2
861a396
PR-URL: #37191
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@ruyadorno@danielleadams
deps: upgrade npm to 7.5.2
e63b380
PR-URL: #37191
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This was referenced Feb 16, 2021
Closed
Merged
@wraithgar
wraithgar deleted the npm-7.5.2 branch June 26, 2025 15:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+1 more reviewer
@MylesBorinsMylesBorinsMylesBorins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.npmIssues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ruyadorno@nodejs-github-bot@targos@MylesBorins@Trott@gireeshpunathil@aduh95