Skip to content

doc: add dmabupt to collaborators - #37377

Closed
dmabupt wants to merge 1 commit into
nodejs:masterfrom
dmabupt:onboardme
Closed

doc: add dmabupt to collaborators#37377
dmabupt wants to merge 1 commit into
nodejs:masterfrom
dmabupt:onboardme

Conversation

@dmabupt

@dmabuptdmabupt commented Feb 15, 2021

Copy link
Copy Markdown
Contributor

Fixes: #36569

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 15, 2021
@dmabupt

dmabupt commented Feb 15, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Please 👍 for fast-tracking

@gireeshpunathilgireeshpunathil added notable-change PRs with changes that should be highlighted in changelogs. meta Issues and PRs related to the general management of the project. labels Feb 15, 2021
@gireeshpunathil

gireeshpunathil commented Feb 15, 2021

Copy link
Copy Markdown
Member

pls note that this is earmarked for landing by @dmabupt per process. we were supposed to land it today itself as part of the onboarding, but it became late for them while we waited for approvals to come in. so leave it open for Xu Meng, for landing it tomorrow.

@dmabupt

dmabupt commented Feb 15, 2021

Copy link
Copy Markdown
ContributorAuthor

landed in 841c3e13f5d5a3d558413f856efea3beac8d758b

@dmabuptdmabupt closed this Feb 15, 2021
@gireeshpunathil

gireeshpunathil commented Feb 15, 2021

Copy link
Copy Markdown
Member

@dmabupt - I don't think it has landed - as I cannot see the commit in master. let us look at it tomorrow, if it is not fixed by then.

@Trott

Trott commented Feb 15, 2021

Copy link
Copy Markdown
Member

Definitely not landed. Re-opening.

@TrottTrott reopened this Feb 15, 2021
@Trott

Trott commented Feb 15, 2021

Copy link
Copy Markdown
Member

landed in 841c3e1

This was pushed to the master branch on @dmabupt's fork, but not here.

@dmabupt

dmabupt commented Feb 15, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

landed in 841c3e1

This was pushed to the master branch on @dmabupt's fork, but not here.

Ah.. Yes, I set the wrong upstream url to fix an error --

$ git push upstream master
fatal: remote error: You can't push to git://github.com/nodejs/node.git
Use https://github.com/nodejs/node.git
$ git remote rm upstream
$ git remote add upstream git@github.com:dmabupt/node.git <-- wrong url!
$ git push upstream master

It should be git@github.com:nodejs/node.git

dmabupt added a commit that referenced this pull request Feb 15, 2021
@dmabupt
doc: add dmabupt to collaborators
eec20ed
PR-URL: #37377
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com
@dmabupt

dmabupt commented Feb 15, 2021

Copy link
Copy Markdown
ContributorAuthor

landed in eec20ed

@dmabuptdmabupt closed this Feb 16, 2021
@gireeshpunathilgireeshpunathil mentioned this pull request Feb 16, 2021
Closed
@dmabupt
dmabupt deleted the onboardme branch February 16, 2021 02:03
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@dmabupt@danielleadams
doc: add dmabupt to collaborators
d808db2
PR-URL: #37377
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com
danielleadams added a commit that referenced this pull request Feb 16, 2021
@danielleadams
2021-02-16, Version 15.9.0 (Current)
5133659
Notable Changes:
* crypto:
* add keyObject.export() 'jwk' format option (Filip Skokan) #37081
* deps:
* upgrade to libuv 1.41.0 (Colin Ihrig) #37360
* doc:
* add dmabupt to collaborators (Xu Meng) #37377
* refactor fs docs structure (James M Snell) #37170
* fs:
* add fsPromises.watch() (James M Snell) #37179
* use a default callback for fs.close() (James M Snell) #37174
* add AbortSignal support to watch (Benjamin Gruenbaum) #37190
* perf_hooks:
* introduce createHistogram (James M Snell) #37155
* stream:
* improve Readable.from error handling (Benjamin Gruenbaum) #37158
* timers:
* introduce setInterval async iterator (linkgoron) #37153
* tls:
* add ability to get cert/peer cert as X509Certificate object (James M Snell) #37070
This was referenced Feb 16, 2021
Closed
Merged
danielleadams added a commit that referenced this pull request Feb 17, 2021
@danielleadams
2021-02-17, Version 15.9.0 (Current)
889ffde
Notable Changes:
* crypto:
* add keyObject.export() 'jwk' format option (Filip Skokan) #37081
* deps:
* upgrade to libuv 1.41.0 (Colin Ihrig) #37360
* doc:
* add dmabupt to collaborators (Xu Meng) #37377
* refactor fs docs structure (James M Snell) #37170
* fs:
* add fsPromises.watch() (James M Snell) #37179
* use a default callback for fs.close() (James M Snell) #37174
* add AbortSignal support to watch (Benjamin Gruenbaum) #37190
* perf_hooks:
* introduce createHistogram (James M Snell) #37155
* stream:
* improve Readable.from error handling (Benjamin Gruenbaum) #37158
* timers:
* introduce setInterval async iterator (linkgoron) #37153
* tls:
* add ability to get cert/peer cert as X509Certificate object (James M Snell) #37070
danielleadams added a commit that referenced this pull request Feb 17, 2021
@danielleadams
2021-02-17, Version 15.9.0 (Current)
877f66e
PR-URL: #37406
Notable Changes:
* crypto:
* add keyObject.export() jwk format option (Filip Skokan) #37081
* deps:
* upgrade to libuv 1.41.0 (Colin Ihrig) #37360
* doc:
* add dmabupt to collaborators (Xu Meng) #37377
* refactor fs docs structure (James M Snell) #37170
* fs:
* add fsPromises.watch() (James M Snell) #37179
* use a default callback for fs.close() (James M Snell) #37174
* add AbortSignal support to watch (Benjamin Gruenbaum) #37190
* perf_hooks:
* introduce createHistogram (James M Snell) #37155
* stream:
* improve Readable.from error handling (Benjamin Gruenbaum) #37158
* timers:
* introduce setInterval async iterator (linkgoron) #37153
* tls:
* add ability to get cert/peer cert as X509Certificate object (James M Snell) #37070
danielleadams added a commit that referenced this pull request Feb 18, 2021
@danielleadams
2021-02-17, Version 15.9.0 (Current)
3bf50a7
PR-URL: #37406
Notable Changes:
* crypto:
* add keyObject.export() jwk format option (Filip Skokan) #37081
* deps:
* upgrade to libuv 1.41.0 (Colin Ihrig) #37360
* doc:
* add dmabupt to collaborators (Xu Meng) #37377
* refactor fs docs structure (James M Snell) #37170
* fs:
* add fsPromises.watch() (James M Snell) #37179
* use a default callback for fs.close() (James M Snell) #37174
* add AbortSignal support to watch (Benjamin Gruenbaum) #37190
* perf_hooks:
* introduce createHistogram (James M Snell) #37155
* stream:
* improve Readable.from error handling (Benjamin Gruenbaum) #37158
* timers:
* introduce setInterval async iterator (linkgoron) #37153
* tls:
* add ability to get cert/peer cert as X509Certificate object (James M Snell) #37070
gimyhendrix7
gimyhendrix7 reviewed Mar 3, 2021
View reviewed changes

@gimyhendrix7gimyhendrix7 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#20494

targos pushed a commit that referenced this pull request May 1, 2021
@dmabupt@targos
doc: add dmabupt to collaborators
07130c0
PR-URL: #37377
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@richardlaurichardlaurichardlau approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+1 more reviewer
@gimyhendrix7gimyhendrix7gimyhendrix7 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.metaIssues and PRs related to the general management of the project.notable-changePRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nominating Xu Meng as as Node.js collaborator

7 participants

@dmabupt@gireeshpunathil@Trott@jasnell@richardlau@gimyhendrix7@nodejs-github-bot