test: validate no debug info for http2

[mhdawson]

Refs: #31763

This test would have helped us catch the noisy output
from http2 earlier. Currently none of the tests
fail if there is unexpected debug output.

Signed-off-by: Michael Dawson mdawson@devrus.com

[lpinca]

If --debug-nghttp2 is used the noisy output is expected, no?

[mhdawson]

@lpinca I was on the fence about that but I don't think people will be planning to ship binaries with that noisy output enabled and having a test failure that helps avoid that is useful since we have already seen it happen.

In terms of impact to a regular test flow I'm surprised that tests did not already fail as there are tests in other areas that would with extra debug output. ie when you turn on a bunch of extra debug output I don't think there is an expectation that all of the tests will pass.

So the net is that I'm thinking its no impact to people using the tests and adds value by helping to avoid a situation we already saw happen.

[lpinca]

Ok, it makes sense, thank you.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/36312/

[mhdawson]

CI is good, going to land

[mhdawson]

We'll git-node land tells me the last CI failed, not sure why but will run another one.

[mhdawson]

New CI https://ci.nodejs.org/job/node-test-pull-request/36321/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/36321/

[richardlau]

We'll git-node land tells me the last CI failed, not sure why but will run another one.

It's most likely the failing test-asan GitHub actions run (#37442) which was fixed by #37443.

[mhdawson]

Landed in 4eec919