Skip to content

test: remove FLAKY for test-http2-compat-client-upload-reject - #37462

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:test-http2-flaky
Closed

test: remove FLAKY for test-http2-compat-client-upload-reject#37462
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:test-http2-flaky

Conversation

@Trott

Copy link
Copy Markdown
Member

As far as I know, this test hasn't failed since around the time it was
first reported in 2019.

Closes: #30847

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Feb 20, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

As far as I know, this test hasn't failed since around the time it was
first reported in 2019.
Closes: nodejs#30847

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasnell pushed a commit that referenced this pull request Feb 23, 2021
As far as I know, this test hasn't failed since around the time it was
first reported in 2019.
Closes: #30847
PR-URL: #37462Fixes: #30847
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

Copy link
Copy Markdown
Member

Landed in 80098e6

@jasnelljasnell closed this Feb 23, 2021
targos pushed a commit that referenced this pull request Feb 28, 2021
As far as I know, this test hasn't failed since around the time it was
first reported in 2019.
Closes: #30847
PR-URL: #37462Fixes: #30847
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Mar 2, 2021
targos pushed a commit that referenced this pull request May 1, 2021
As far as I know, this test hasn't failed since around the time it was
first reported in 2019.
Closes: #30847
PR-URL: #37462Fixes: #30847
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
@Trott
Trott deleted the test-http2-flaky branch September 25, 2022 17:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate flaky test parallel/test-http2-compat-client-upload-reject

7 participants

@Trott@nodejs-github-bot@jasnell@lpinca@targos@mhdawson@marsonya