Skip to content

contextify: cache some context in locals - #37473

Closed
XadillaX wants to merge 2 commits into
nodejs:masterfrom
XadillaX:ctx
Closed

contextify: cache some context in locals#37473
XadillaX wants to merge 2 commits into
nodejs:masterfrom
XadillaX:ctx

Conversation

@XadillaX

@XadillaXXadillaX commented Feb 22, 2021

Copy link
Copy Markdown
Contributor

Refs: 66566df

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. vm Issues and PRs related to the vm subsystem. labels Feb 22, 2021
@XadillaX

XadillaX commented Feb 24, 2021

Copy link
Copy Markdown
ContributorAuthor

/ping @nodejs/vm

targos
targos reviewed Feb 24, 2021
View reviewed changes
Comment threadsrc/node_contextify.cc Outdated
@XadillaX

XadillaX commented Mar 1, 2021

Copy link
Copy Markdown
ContributorAuthor

/ping @targos

@XadillaXXadillaX added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 15, 2021
@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37314/

@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37316/

@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37318/

@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37319/

@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37325/

@nodejs-github-bot

nodejs-github-bot commented Apr 19, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37561/

XadillaX added a commit that referenced this pull request Apr 19, 2021
@XadillaX
src: cache some context in locals
4e9212b
Refs: 66566df
PR-URL: #37473
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@XadillaX

XadillaX commented Apr 19, 2021

Copy link
Copy Markdown
ContributorAuthor

Landed in 4e9212b

@BethGriggsBethGriggs mentioned this pull request Apr 20, 2021
Merged
XadillaX added a commit to XadillaX/node that referenced this pull request Apr 23, 2021
@XadillaX
src: cache necessary isolate & context in api/*
d1f30a6
Refs: nodejs#37473
@XadillaXXadillaX mentioned this pull request Apr 23, 2021
Closed
targos pushed a commit that referenced this pull request May 1, 2021
@XadillaX@targos
src: cache some context in locals
5ed770e
Refs: 66566df
PR-URL: #37473
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
@XadillaX@danielleadams
src: cache some context in locals
6067f95
Refs: 66566df
PR-URL: #37473
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
XadillaX added a commit that referenced this pull request Jun 1, 2021
@XadillaX
src: cache necessary isolate & context in api/*
f52dc17
Refs: #37473
PR-URL: #38366
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 2, 2021
@XadillaX@danielleadams
src: cache necessary isolate & context in api/*
120849f
Refs: #37473
PR-URL: #38366
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@RaisinTenRaisinTen mentioned this pull request Oct 11, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@targostargostargos approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
@devsnekdevsnekAwaiting requested review from devsnek

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@XadillaX@nodejs-github-bot@jasnell@targos@RaisinTen