Skip to content

doc: document the NO_COLOR and FORCE_COLOR env vars - #37477

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:no_color_force-color
Closed

doc: document the NO_COLOR and FORCE_COLOR env vars#37477
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:no_color_force-color

Conversation

@jasnell

@jasnelljasnell commented Feb 22, 2021

Copy link
Copy Markdown
Member

Signed-off-by: James M Snell jasnell@gmail.com
Fixes: #37404

@jasnelljasnell mentioned this pull request Feb 22, 2021
Closed
Trott
Trott reviewed Feb 22, 2021
View reviewed changes
Comment threaddoc/api/cli.md Outdated
Trott
Trott reviewed Feb 22, 2021
View reviewed changes
Comment threaddoc/api/cli.md Outdated
Trott
Trott reviewed Feb 22, 2021
View reviewed changes
Comment threaddoc/api/cli.md Outdated
@Trott

Trott commented Feb 22, 2021

Copy link
Copy Markdown
Member

These entries need to be duplicated into doc/node.1 so that they show up in the man page.

lpinca
lpinca approved these changes Feb 22, 2021
View reviewed changes

@lpincalpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @Trott's nits addressed.

Trott
Trott reviewed Feb 23, 2021
View reviewed changes
Comment threaddoc/api/cli.md Outdated
Trott
Trott previously requested changes Feb 23, 2021
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but leaving a "Request changes" until the entries are in doc/node.1 as well. Feel free to dismiss this review once that's happened.

@jasnell
jasnellforce-pushed the no_color_force-color branch from e9a759f to 1d4d8b2CompareFebruary 23, 2021 15:22
@jasnelljasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. labels Feb 23, 2021
BridgeAR
BridgeAR reviewed Feb 23, 2021
View reviewed changes

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments.

Comment threaddoc/api/cli.md Outdated
Comment threaddoc/api/cli.md Outdated
@BridgeARBridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 23, 2021
@jasnell
jasnellforce-pushed the no_color_force-color branch from 1d4d8b2 to ff754feCompareFebruary 25, 2021 22:38
@jasnell
doc: document the NO_COLOR and FORCE_COLOR env vars
95b0fe7
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: nodejs#37404
@jasnell
jasnellforce-pushed the no_color_force-color branch from ff754fe to 95b0fe7CompareFebruary 25, 2021 22:43
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Feb 26, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36378/

@nodejs-github-bot

nodejs-github-bot commented Feb 26, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36380/

@jasnell

jasnell commented Feb 26, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in fc6d8f4

@jasnelljasnell closed this Feb 26, 2021
jasnell added a commit that referenced this pull request Feb 26, 2021
@jasnell
doc: document the NO_COLOR and FORCE_COLOR env vars
fc6d8f4
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #37404
PR-URL: #37477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@sthagensthagen mentioned this pull request Feb 27, 2021
Merged
targos pushed a commit that referenced this pull request Feb 28, 2021
@jasnell@targos
doc: document the NO_COLOR and FORCE_COLOR env vars
3b7cb75
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #37404
PR-URL: #37477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Mar 2, 2021
Merged
Alhadis
Alhadis reviewed Mar 5, 2021
View reviewed changes
Comment threaddoc/node.1
Comment on lines +535 to +536
.Ar 1
,

@AlhadisAlhadisMar 5, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most mdoc(7) macros allow authors to include trailing punctuation as a separate (final) argument:

.Ar1 ,

See the "Delimiters" section of mdoc(7) for more info on this feature.

targos pushed a commit that referenced this pull request May 27, 2021
@jasnell@targos
doc: document the NO_COLOR and FORCE_COLOR env vars
7a67a90
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #37404
PR-URL: #37477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 30, 2021
@jasnell@targos
doc: document the NO_COLOR and FORCE_COLOR env vars
5cf0b58
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #37404
PR-URL: #37477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@jasnell@targos
doc: document the NO_COLOR and FORCE_COLOR env vars
f0daaec
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #37404
PR-URL: #37477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targostargos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@jasnell@targos
doc: document the NO_COLOR and FORCE_COLOR env vars
2168e95
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #37404
PR-URL: #37477
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@ElectroidElectroid mentioned this pull request May 24, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeARBridgeARBridgeAR left review comments
@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@aduh95aduh95aduh95 approved these changes
@juanarboljuanarboljuanarbol approved these changes
+1 more reviewer
@AlhadisAlhadisAlhadis left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please document FORCE_COLOR/NO_COLOR in node -h output

8 participants

@jasnell@Trott@nodejs-github-bot@lpinca@Alhadis@BridgeAR@aduh95@juanarbol