Skip to content

doc: add url.resolve replacement example - #37501

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:url-resolve-whatwg
Feb 26, 2021
Merged

doc: add url.resolve replacement example#37501
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:url-resolve-whatwg

Conversation

@aduh95

Copy link
Copy Markdown
Contributor

Fixes: #37492

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Feb 24, 2021
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 24, 2021
Fixes: nodejs#37492
PR-URL: nodejs#37501
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@aduh95
aduh95 merged commit 5d240c5 into nodejs:masterFeb 26, 2021
@aduh95

Copy link
Copy Markdown
ContributorAuthor

Landed in 5d240c5

@aduh95
aduh95 deleted the url-resolve-whatwg branch February 26, 2021 15:36
targos pushed a commit that referenced this pull request Feb 28, 2021
Fixes: #37492
PR-URL: #37501
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targostargos mentioned this pull request Mar 2, 2021
targos pushed a commit that referenced this pull request May 1, 2021
Fixes: #37492
PR-URL: #37501
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.urlIssues and PRs related to the legacy built-in url module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please un-deprecate url.resolve

5 participants

@aduh95@jasnell@marsonya@RaisinTen@nodejs-github-bot