Skip to content

doc: apply sentence case to headers in doc/guides - #37506

Merged
Trott merged 1 commit into
nodejs:masterfrom
marsonya:sentence-case-3
Feb 27, 2021
Merged

doc: apply sentence case to headers in doc/guides#37506
Trott merged 1 commit into
nodejs:masterfrom
marsonya:sentence-case-3

Conversation

@marsonya

Copy link
Copy Markdown
Member

changes as per doc styling guidelines

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 24, 2021
@Trott

Copy link
Copy Markdown
Member

Optional nit: It would be good for this and the other PR with the same commit message to specify the files changed. It can be in the commit body if there's no room in the first line.

@marsonya

Copy link
Copy Markdown
MemberAuthor

Optional nit: It would be good for this and the other PR with the same commit message to specify the files changed. It can be in the commit body if there's no room in the first line.

Sure. I will specify file description in comit message/body.

PR-URL: #37506
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@Trott
Trott merged commit 0486cb8 into nodejs:masterFeb 27, 2021
@Trott

Copy link
Copy Markdown
Member

Landed in 0486cb8

targos pushed a commit that referenced this pull request Feb 28, 2021
PR-URL: #37506
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targostargos mentioned this pull request Mar 2, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37506
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@marsonya@Trott@RaisinTen@HarshithaKP@PoojaDurgad@nodejs-github-bot