Skip to content

test: remove FLAKY status for test-http2-multistream-destroy-on-read-tls - #37533

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:remove-from-status
Mar 1, 2021
Merged

test: remove FLAKY status for test-http2-multistream-destroy-on-read-tls#37533
Trott merged 1 commit into
nodejs:masterfrom
Trott:remove-from-status

Conversation

@Trott

Copy link
Copy Markdown
Member

The test does not seem to have failed since the issue was first reported
in 2019.

Closes: #30845

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 27, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

The test does not seem to have failed since the issue was first reported
in 2019.
Closes: nodejs#30845
PR-URL: nodejs#37533Fixes: nodejs#30845
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Trottforce-pushed the remove-from-status branch from 76427a4 to 2748b0aCompareMarch 1, 2021 20:20
@Trott

Trott commented Mar 1, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in 2748b0a

@Trott
Trott merged commit 2748b0a into nodejs:masterMar 1, 2021
@Trott
Trott deleted the remove-from-status branch March 1, 2021 20:20
targos pushed a commit that referenced this pull request Mar 2, 2021
The test does not seem to have failed since the issue was first reported
in 2019.
Closes: #30845
PR-URL: #37533Fixes: #30845
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Mar 2, 2021
targos pushed a commit that referenced this pull request May 1, 2021
The test does not seem to have failed since the issue was first reported
in 2019.
Closes: #30845
PR-URL: #37533Fixes: #30845
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate flaky test parallel/test-http2-multistream-destroy-on-read-tls

5 participants

@Trott@nodejs-github-bot@jasnell@lpinca@cjihrig