Skip to content

doc: document that NODE_EXTRA_CA_CERTS is read only once - #37562

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:clarify-node-extra-ca-certs
Closed

doc: document that NODE_EXTRA_CA_CERTS is read only once#37562
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:clarify-node-extra-ca-certs

Conversation

@jasnell

@jasnelljasnell commented Mar 1, 2021

Copy link
Copy Markdown
Member

Fixes: #20432

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 1, 2021
mhdawson
mhdawson approved these changes Mar 1, 2021
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as documenting current behavior

@jasnell

jasnell commented Mar 5, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in 9c1274a

@jasnelljasnell closed this Mar 5, 2021
jasnell added a commit that referenced this pull request Mar 5, 2021
@jasnell
doc: document that NODE_EXTRA_CA_CERTS is read only once
9c1274a
Fixes: #20432
PR-URL: #37562
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@jasnell@danielleadams
doc: document that NODE_EXTRA_CA_CERTS is read only once
267bbe3
Fixes: #20432
PR-URL: #37562
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Mar 16, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@jasnell@targos
doc: document that NODE_EXTRA_CA_CERTS is read only once
c21731b
Fixes: #20432
PR-URL: #37562
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NODE_EXTRA_CA_CERTS cannot be set in code or relative

5 participants

@jasnell@lpinca@richardlau@mhdawson@nodejs-github-bot