Skip to content

doc: clarify that columnOffset applies only to the first line - #37563

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:clarify-vm-columnoffset
Closed

doc: clarify that columnOffset applies only to the first line#37563
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:clarify-vm-columnoffset

Conversation

@jasnell

@jasnelljasnell commented Mar 1, 2021

Copy link
Copy Markdown
Member

Fixes: #26780

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Mar 1, 2021
mcollina
mcollina approved these changes Mar 5, 2021
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jasnell added a commit that referenced this pull request Mar 5, 2021
@jasnell
doc: clarify that columnOffset applies only to the first line
ee58b2d
Fixes: #26780
PR-URL: #37563
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell

jasnell commented Mar 5, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in ee58b2d

@jasnelljasnell closed this Mar 5, 2021
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@jasnell@danielleadams
doc: clarify that columnOffset applies only to the first line
732d8ca
Fixes: #26780
PR-URL: #37563
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Mar 16, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@jasnell@targos
doc: clarify that columnOffset applies only to the first line
1dc7f42
Fixes: #26780
PR-URL: #37563
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@lpincalpincalpinca approved these changes
@marsonyamarsonyamarsonya approved these changes

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VM: options.columnOffset has no effect on column number in stack trace output

5 participants

@jasnell@mcollina@lpinca@marsonya@nodejs-github-bot