Skip to content

doc: fix small typo in 15.11.0 release - #37590

Closed
bnb wants to merge 1 commit into
nodejs:masterfrom
bnb:bnb/changelog-typo-fix
Closed

doc: fix small typo in 15.11.0 release#37590
bnb wants to merge 1 commit into
nodejs:masterfrom
bnb:bnb/changelog-typo-fix

Conversation

@bnb

@bnbbnb commented Mar 3, 2021

Copy link
Copy Markdown
Contributor

Noticed a small typo in the changelog for the release today while writing a tweet for it, wanted to help fix it. Since this typo is directly committed and is in the commit message, I'm not sure if this can/should land but figured I'd throw it up on the possibility that folks think it should land.

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 3, 2021
@bnb

bnb commented Mar 3, 2021

Copy link
Copy Markdown
ContributorAuthor

did my best with the commit message naming, if doc: is more correct than changelog: happy to fix that.

@bnb
bnbforce-pushed the bnb/changelog-typo-fix branch from 4a47a68 to 121051aCompareMarch 3, 2021 18:56
@bnb

bnb commented Mar 3, 2021

Copy link
Copy Markdown
ContributorAuthor

removed the change in the auto-generated bit and to just update the Notable Changes bit, per advice from @MylesBorins.

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RaisinTen

Copy link
Copy Markdown
Member

Looking at the last two typo fixes in this changelog (#37229 and #35804), it seems doc: is preferred over changelog:.

@bnb

bnb commented Mar 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Will update that today 👍🏻

@bnb
bnbforce-pushed the bnb/changelog-typo-fix branch from 121051a to e6786e5CompareMarch 4, 2021 21:26
@bnbbnb changed the title changelog: fix small typo in 15.11.0 releasedoc: fix small typo in 15.11.0 releaseMar 4, 2021
@bnb

bnb commented Mar 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Force pushed over the previous commit to use the doc prefix ❤️

@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2021
@bnb

bnb commented Mar 5, 2021

Copy link
Copy Markdown
ContributorAuthor

The failed macOS build is unrelated to the contents of this PR 😬

@jasnelljasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 5, 2021
jasnell pushed a commit that referenced this pull request Mar 5, 2021
PR-URL: #37590
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

Copy link
Copy Markdown
Member

Landed in ed633f2

@jasnelljasnell closed this Mar 5, 2021
@bnb
bnb deleted the bnb/changelog-typo-fix branch March 11, 2021 15:52
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
PR-URL: #37590
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Mar 16, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@bnb@RaisinTen@jasnell@MylesBorins@Trott@lpinca@marsonya@targos@nodejs-github-bot