Uh oh!
There was an error while loading. Please reload this page.
src: add error formatting support - #37598
Merged
Merged
Conversation
devsnekforce-pushed
the
better-native-errors
branch
from
March 4, 2021 04:29
79a1cce to
db938cfCompareUh oh!
There was an error while loading. Please reload this page.
devsnekforce-pushed
the
better-native-errors
branch
from
March 5, 2021 17:10
db938cf to
caaffe6Comparedevsnekforce-pushed
the
better-native-errors
branch
from
March 5, 2021 17:28
caaffe6 to
21b4ee7Comparejasnell
approved these changes
Mar 5, 2021
nodejs-github-bot
commented
Mar 5, 2021
Collaborator
RaisinTen
approved these changes
Mar 6, 2021
nodejs-github-bot
commented
Mar 6, 2021
Collaborator
targos
commented
Mar 6, 2021
Member
Does this need a documentation update (for the error code) ? |
nodejs-github-bot
commented
Mar 6, 2021
Collaborator
devsnekforce-pushed
the
better-native-errors
branch
from
March 9, 2021 00:07
21b4ee7 to
4434596Comparenodejs-github-bot
commented
Mar 9, 2021
Collaborator
targos
approved these changes
Mar 9, 2021
devsnek
commented
Mar 9, 2021
MemberAuthor
Is "rebuild" or "retry" the correct button for just doing the failed runners |
targos
commented
Mar 9, 2021
Member
The correct button is "Resume build" |
devsnek
commented
Mar 9, 2021
MemberAuthor
Close enough 😄 |
nodejs-github-bot
commented
Mar 9, 2021
Collaborator
PR-URL: nodejs#37598 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
devsnekforce-pushed
the
better-native-errors
branch
from
March 9, 2021 16:14
4434596 to
853086fComparedevsnek
commented
Mar 9, 2021
MemberAuthor
landed in 853086f |
danielleadams pushed a commit
that referenced
this pull request
Mar 16, 2021
PR-URL: #37598 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
targos pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #37598 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the use of format strings in our native error functions. It also includes some light usage in ModuleWrap.