Uh oh!
There was an error while loading. Please reload this page.
doc: add return type of readline.createInterface - #37600
Merged
aduh95 merged 1 commit intoMar 6, 2021
Merged
Conversation
lpinca
approved these changes
Mar 4, 2021
marsonya
approved these changes
Mar 4, 2021
benjamingr
approved these changes
Mar 4, 2021
benjamingr
commented
Mar 4, 2021
Member
Good catch |
Trott
approved these changes
Mar 4, 2021
jasnell
approved these changes
Mar 5, 2021
jasnell
commented
Mar 5, 2021
Member
fast-track? |
PR-URL: nodejs#37600 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95force-pushed
the
doc/add-return-type-of-readline.createInterface
branch
from
March 6, 2021 17:54
4b1e3f4 to
d63b717Compareaduh95
commented
Mar 6, 2021
Contributor
Landed in d63b717 |
danielleadams pushed a commit
that referenced
this pull request
Mar 16, 2021
PR-URL: #37600 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #37600 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.