Skip to content

doc: apply sentence case to headers in doc/guides/contributing/pull-requests.md - #37602

Merged
Trott merged 1 commit into
nodejs:masterfrom
marsonya:sentence-case-5
Mar 6, 2021
Merged

doc: apply sentence case to headers in doc/guides/contributing/pull-requests.md#37602
Trott merged 1 commit into
nodejs:masterfrom
marsonya:sentence-case-5

Conversation

@marsonya

Copy link
Copy Markdown
Member

changes as per doc styling guidelines

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 4, 2021
Comment threaddoc/guides/contributing/pull-requests.md Outdated
@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2021
@jasnelljasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 5, 2021
@jasnell

Copy link
Copy Markdown
Member

fast-track?

PR-URL: #37602
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

Trott commented Mar 6, 2021

Copy link
Copy Markdown
Member

Landed in 7c7b983

@Trott
Trott merged commit 7c7b983 into nodejs:masterMar 6, 2021
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
PR-URL: #37602
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Mar 16, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37602
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@marsonya@jasnell@Trott@RaisinTen@nodejs-github-bot