Skip to content

doc: change lang info string in fs JS snippets - #37605

Merged
Trott merged 1 commit into
nodejs:masterfrom
aduh95:fs-lang-fenced
Mar 6, 2021
Merged

doc: change lang info string in fs JS snippets #37605
Trott merged 1 commit into
nodejs:masterfrom
aduh95:fs-lang-fenced

Conversation

@aduh95

@aduh95aduh95 commented Mar 4, 2021

Copy link
Copy Markdown
Contributor

@aduh95aduh95 added doc Issues and PRs related to the documentations. blocked PRs that are blocked by other issues or PRs. labels Mar 4, 2021
@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 4, 2021
@aduh95aduh95 removed the blocked PRs that are blocked by other issues or PRs. label Mar 4, 2021
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed tools Issues and PRs related to the tools directory. labels Mar 4, 2021
@jasnelljasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 5, 2021
@jasnell

Copy link
Copy Markdown
Member

fast-track?

@aduh95aduh95 self-assigned this Mar 5, 2021
@aduh95

Copy link
Copy Markdown
ContributorAuthor

Anyone wants to 👍 the fast track request so I can land #37311?

Refs: nodejs/remark-preset-lint-node#176
PR-URL: nodejs#37605
Refs: nodejs#37162
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@Trott

Trott commented Mar 6, 2021

Copy link
Copy Markdown
Member

Landed in 0946164

@Trott
Trott merged commit 0946164 into nodejs:masterMar 6, 2021
@aduh95
aduh95 deleted the fs-lang-fenced branch March 6, 2021 15:03
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
Refs: nodejs/remark-preset-lint-node#176
PR-URL: #37605
Refs: #37162
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Mar 16, 2021
targos pushed a commit to targos/node that referenced this pull request Aug 8, 2021
Refs: nodejs/remark-preset-lint-node#176
PR-URL: nodejs#37605
Refs: nodejs#37162
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Sep 1, 2021
Refs: nodejs/remark-preset-lint-node#176
PR-URL: nodejs#37605
Refs: nodejs#37162
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request Sep 1, 2021
Refs: nodejs/remark-preset-lint-node#176
PR-URL: #37605
Refs: #37162
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targostargos mentioned this pull request Sep 4, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@aduh95@jasnell@Trott@benjamingr@danielleadams@marsonya@RaisinTen@targos@nodejs-github-bot