Uh oh!
There was an error while loading. Please reload this page.
doc: add esm examples for assert - #37607
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Trott
commented
Mar 5, 2021
@nodejs/documentation @nodejs/assert @nodejs/modules |
Trott
commented
Mar 5, 2021
I hesitate to say this because I know doing this was a lot of work to begin with, but I'm with @aduh95 on the named imports. I'd prefer we do default exports because (Full disclosure: I happen to think destructuring/named imports are a bit of an anti-pattern. If I have two modules with a |
jasnell
commented
Mar 5, 2021
What?! Lol... I'm not worried about the work involved, it's really not that much. |
Signed-off-by: James M Snell <jasnell@gmail.com>
5e11215 to
2306a36Comparejasnell
commented
Mar 5, 2021
There, I fixed it for you picky folk 😁🤣 |
ljharb
commented
Mar 5, 2021
altho tbh the |
jasnell
commented
Mar 5, 2021
jasnell
commented
Mar 8, 2021
Landed in a8b5cdc |
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37607 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37607 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

ESM example variants in preparation for #37162
/cc @aduh95
Signed-off-by: James M Snell jasnell@gmail.com