Skip to content

test: terminate WPT workers after test completion - #37627

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:wpt-worker
Closed

test: terminate WPT workers after test completion#37627
targos wants to merge 1 commit into
nodejs:masterfrom
targos:wpt-worker

Conversation

@targos

@targostargos commented Mar 6, 2021

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 6, 2021
aduh95
aduh95 reviewed Mar 6, 2021
View reviewed changes
Comment threadtest/common/wpt.js
this.inProgress.delete(filename);
// Always force termination of the worker. Some tests allocate resources
// that would otherwise keep it alive.
this.workers.get(filename).terminate();

@aduh95aduh95Mar 6, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's safe to ignore the Promise status, maybe add an empty catch handler?

Suggested change
this.workers.get(filename).terminate();
this.workers.get(filename).terminate().catch(()=>{});

@targostargosMar 6, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This promise can never reject

node/lib/internal/worker.js

Lines 344 to 354 in f3d3769

if(this[kHandle]===null)returnPromiseResolve();
this[kHandle].stopThread();
// Do not use events.once() here, because the 'exit' event will always be
// emitted regardless of any errors, and the point is to only resolve
// once the thread has actually stopped.
returnnewPromise((resolve)=>{
this.once('exit',resolve);
});
}

@nodejs-github-bot

nodejs-github-bot commented Mar 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36510/

@nodejs-github-bot

nodejs-github-bot commented Mar 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36541/

@nodejs-github-bot

nodejs-github-bot commented Mar 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36545/

@nodejs-github-bot

nodejs-github-bot commented Mar 8, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36546/

targos added a commit that referenced this pull request Mar 8, 2021
@targos
test: terminate WPT workers after test completion
bba5aac
PR-URL: #37627
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos

targos commented Mar 8, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in bba5aac

@targostargos closed this Mar 8, 2021
@targos
targos deleted the wpt-worker branch March 8, 2021 20:57
@targostargos mentioned this pull request Mar 9, 2021
Closed
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@targos@danielleadams
test: terminate WPT workers after test completion
f7edb07
PR-URL: #37627
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Mar 16, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@targos@nodejs-github-bot@Trott@aduh95