Skip to content

test: remove FLAKY status for fixed test - #37633

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:status-only
Mar 8, 2021
Merged

test: remove FLAKY status for fixed test#37633
Trott merged 1 commit into
nodejs:masterfrom
Trott:status-only

Conversation

@Trott

@TrottTrott commented Mar 6, 2021

Copy link
Copy Markdown
Member

test-worker-message-port-transfer-terminate was fixed in
25447d8 but the status file was not updated to reflect this.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 6, 2021
@nodejs-github-bot

nodejs-github-bot commented Mar 6, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36517/

@PoojaDurgadPoojaDurgad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2021
@Trott
test: remove FLAKY status for fixed test
5cea29b
test-worker-message-port-transfer-terminate was fixed in
25447d8 but the status file was not updated to reflect this.
PR-URL: nodejs#37633
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott

Trott commented Mar 8, 2021

Copy link
Copy Markdown
MemberAuthor

Landed in 5cea29b

@Trott
Trott merged commit 5cea29b into nodejs:masterMar 8, 2021
@Trott
Trott deleted the status-only branch March 8, 2021 17:38
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@Trott@danielleadams
test: remove FLAKY status for fixed test
044fd2f
test-worker-message-port-transfer-terminate was fixed in
25447d8 but the status file was not updated to reflect this.
PR-URL: #37633
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Mar 16, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott@targos
test: remove FLAKY status for fixed test
a91a200
test-worker-message-port-transfer-terminate was fixed in
25447d8 but the status file was not updated to reflect this.
PR-URL: #37633
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott@nodejs-github-bot@targos@cjihrig@richardlau@PoojaDurgad