Skip to content

test,crypto: ensure promises resolve in webcrypto tests - #37653

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:webcrypt-assert-rejects
Mar 13, 2021
Merged

test,crypto: ensure promises resolve in webcrypto tests#37653
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:webcrypt-assert-rejects

Conversation

@aduh95

Copy link
Copy Markdown
Contributor

No description provided.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 8, 2021
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 9, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

PR-URL: nodejs#37653
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95
aduh95force-pushed the webcrypt-assert-rejects branch from a09d601 to dc8d54dCompareMarch 13, 2021 09:37
@aduh95

Copy link
Copy Markdown
ContributorAuthor

Landed in dc8d54d

@aduh95aduh95 closed this Mar 13, 2021
@aduh95
aduh95 merged commit dc8d54d into nodejs:masterMar 13, 2021
@aduh95
aduh95 deleted the webcrypt-assert-rejects branch March 13, 2021 09:38
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
PR-URL: #37653
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Mar 16, 2021
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
PR-URL: #37653
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95@nodejs-github-bot@jasnell@Trott@targos