Skip to content

test: remove unnecessary V8 flag - #37671

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:weak-ref-harmony
Mar 9, 2021
Merged

test: remove unnecessary V8 flag#37671
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:weak-ref-harmony

Conversation

@aduh95

Copy link
Copy Markdown
Contributor

I'm trying to remove the flag upstream.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 9, 2021
@aduh95aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 9, 2021
@aduh95

Copy link
Copy Markdown
ContributorAuthor

fast-track?

@aduh95aduh95 mentioned this pull request Mar 9, 2021
4 tasks
@aduh95aduh95 removed the needs-ci PRs that need a full CI run. label Mar 9, 2021
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582
PR-URL: nodejs#37671
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@aduh95

Copy link
Copy Markdown
ContributorAuthor

Landed in 5247dc0

@aduh95
aduh95 merged commit 5247dc0 into nodejs:masterMar 9, 2021
@aduh95
aduh95 deleted the weak-ref-harmony branch March 9, 2021 15:24
aduh95 added a commit to aduh95/node that referenced this pull request Mar 15, 2021
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582
PR-URL: nodejs#37671
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582
PR-URL: #37671
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@danielleadamsdanielleadams mentioned this pull request Mar 16, 2021
targos pushed a commit that referenced this pull request May 1, 2021
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/2741582
PR-URL: #37671
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95@lpinca@targos@devsnek@nodejs-github-bot