Skip to content

crypto: reconcile duplicated code - #37704

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:reconcile-crypto-dup-code
Closed

crypto: reconcile duplicated code#37704
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:reconcile-crypto-dup-code

Conversation

@jasnell

Copy link
Copy Markdown
Member

/cc @panva

Signed-off-by: James M Snell jasnell@gmail.com

Signed-off-by: James M Snell <jasnell@gmail.com>
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 11, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@panvapanva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Mar 11, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

nodejs-github-bot commented Mar 11, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36618/ 💚

@panva

Copy link
Copy Markdown
Member

Landed in e76d762

@panvapanva closed this Mar 13, 2021
panva pushed a commit that referenced this pull request Mar 13, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #37704
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #37704
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Mar 16, 2021
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #37704
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jasnell@nodejs-github-bot@panva@aduh95@targos