Skip to content

deps: upgrade npm to 7.6.3 - #37721

Closed
ruyadorno wants to merge 1 commit into
nodejs:masterfrom
npm:npm-7.6.3
Closed

deps: upgrade npm to 7.6.3#37721
ruyadorno wants to merge 1 commit into
nodejs:masterfrom
npm:npm-7.6.3

Conversation

@ruyadorno

@ruyadornoruyadorno commented Mar 11, 2021

Copy link
Copy Markdown
Member

v7.6.3 (2021-03-11)

DOCUMENTATION

DEPENDENCIES

  • 57ed390d6@npmcli/arborist@2.2.8
    • Respect link deps when calculating peerDep sets

v7.6.2 (2021-03-09)

BUG FIXES

DEPENDENCIES

  • 7f470b5c2@npmcli/arborist@2.2.7
    • fix(install): Do not revert a file: dep to version on bare name re-install
  • e9b7fc275libnpmdiff@2.0.4
    • fix(diff): Gracefully handle packages with prepare script
  • c7314aa62byte-size@7.0.1
  • 864f48d43pacote@11.3.0

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Mar 11, 2021
@ruyadornoruyadorno mentioned this pull request Mar 11, 2021
Closed
@nodejs-github-bot

nodejs-github-bot commented Mar 11, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36642/

@ruyadornoruyadorno added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 11, 2021
@ruyadorno

ruyadorno commented Mar 11, 2021

Copy link
Copy Markdown
MemberAuthor

fast-track?

@nodejs-github-bot

nodejs-github-bot commented Mar 12, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36646/

Trott
Trott approved these changes Mar 12, 2021
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@aduh95

aduh95 commented Mar 12, 2021

Copy link
Copy Markdown
Contributor

Do we really need a passing Jenkins CI for an npm update? I believe we don't test anything related to npm that the GitHub Actions CI doesn't already check.

@targos

targos commented Mar 12, 2021

Copy link
Copy Markdown
Member

@aduh95 we have at least one npm test: https://github.com/nodejs/node/blob/master/test/parallel/test-npm-install.js

@ruyadorno

ruyadorno commented Mar 12, 2021

Copy link
Copy Markdown
MemberAuthor

@targos I don't think that one is actually running on CI 😅 I have seen it broken on the main branch and had to manually fix it later many times

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Mar 12, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36658/

@nodejs-github-bot

nodejs-github-bot commented Mar 12, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36666/

Trott pushed a commit that referenced this pull request Mar 13, 2021
@ruyadorno@Trott
deps: upgrade npm to 7.6.3
5fdcfb3
PR-URL: #37721
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Trott

Trott commented Mar 13, 2021

Copy link
Copy Markdown
Member

Landed in 5fdcfb3

@TrottTrott closed this Mar 13, 2021
@Trott

Trott commented Mar 13, 2021

Copy link
Copy Markdown
Member

@aduh95 we have at least one npm test: https://github.com/nodejs/node/blob/master/test/parallel/test-npm-install.js

There's also test-release-npm.js and test-npm-version.js.

danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@ruyadorno@danielleadams
deps: upgrade npm to 7.6.3
efd14a9
PR-URL: #37721
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Mar 16, 2021
Merged
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@ruyadorno@danielleadams
deps: upgrade npm to 7.6.3
3e1a46a
PR-URL: #37721
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@wraithgar
wraithgar deleted the npm-7.6.3 branch June 26, 2025 15:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.npmIssues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ruyadorno@nodejs-github-bot@aduh95@targos@Trott@lpinca