Skip to content

doc: move Derek Lewis back to collaborators - #37726

Merged
Trott merged 1 commit into
nodejs:masterfrom
DerekNonGeneric:derek-collab
Mar 20, 2021
Merged

doc: move Derek Lewis back to collaborators#37726
Trott merged 1 commit into
nodejs:masterfrom
DerekNonGeneric:derek-collab

Conversation

@DerekNonGeneric

Copy link
Copy Markdown
Contributor

Conclude winter break and resume collaboratorship at start of spring.

Refs: #36514


The astronomical start of spring this year is Saturday, March 20, 2021.

Goals for the season include a more sophisticated and polished hook system (pending results of the discussion topic lead by @GeoffreyBooth) for custom loader use (as well as addressing the outstanding bugs in https://github.com/nodejs/modules).

/cc @Trott to check

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 12, 2021

@targostargos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back!

@benjamingrbenjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally LGTM.

As far as I understand our process is that this is brought up to the next TSC meeting :

The TSC can remove inactive Collaborators or provide them with Emeritus status. Emeriti may request that the TSC restore them to active status.

rather than as a pull request.

@benjamingr

Copy link
Copy Markdown
Member

And welcome back <3 :)

@TrottTrott added the blocked PRs that are blocked by other issues or PRs. label Mar 12, 2021
@Trott

Copy link
Copy Markdown
Member

I added the blocked label to make sure this doesn't land before TSC review. Adding the tsc-agenda label too although we may take it up in email before the next meeting rather than waiting until then.

@TrottTrott added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Mar 12, 2021

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GeoffreyBoothGeoffreyBooth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back, and thank you! We could really use your help 😄

@DerekNonGeneric

DerekNonGeneric commented Mar 17, 2021

Copy link
Copy Markdown
ContributorAuthor

I have converted this to a draft to ensure accuracy in timing (my exact availability may be changing) and depending on the results of the meeting.

@TrottTrott removed the blocked PRs that are blocked by other issues or PRs. label Mar 17, 2021
@DerekNonGeneric

DerekNonGeneric commented Mar 20, 2021

Copy link
Copy Markdown
ContributorAuthor

The meeting results appeared positive, so I will keep this open and landable for when I return next month.

Conclude winter break and resume collaboratorship at start of spring.
Refs: #36514
PR-URL: #37726
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@Trott

Copy link
Copy Markdown
Member

Landed in e427c48

@Trott
Trott merged commit e427c48 into nodejs:masterMar 20, 2021
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
Conclude winter break and resume collaboratorship at start of spring.
Refs: #36514
PR-URL: #37726
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@ruyadornoruyadorno mentioned this pull request Mar 30, 2021
targos pushed a commit that referenced this pull request May 1, 2021
Conclude winter break and resume collaboratorship at start of spring.
Refs: #36514
PR-URL: #37726
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.tsc-agendaIssues and PRs to discuss during the meetings of the TSC.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

18 participants

@DerekNonGeneric@benjamingr@Trott@mcollina@ChALkeR@jasnell@GeoffreyBooth@targos@cjihrig@tniessen@richardlau@gireeshpunathil@BethGriggs@mhdawson@aduh95@marsonya@RaisinTen@nodejs-github-bot