Uh oh!
There was an error while loading. Please reload this page.
errors: remove experimental from --enable-source-maps - #37743
Closed
bcoe wants to merge 1 commit into
Closed
Conversation
bcoe
commented
Mar 13, 2021
ContributorAuthor
CC: @Flarna |
Flarna
approved these changes
Mar 13, 2021
ruyadorno
approved these changes
Mar 13, 2021
iansu
approved these changes
Mar 13, 2021
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Mar 14, 2021
Collaborator
Trott
approved these changes
Mar 14, 2021
Trott
commented
Mar 14, 2021
Member
Minor nit: Our guidelines say the first word after the subsystem in the commit message should be an imperative verb. So maybe this?:
|
Flarna
commented
Mar 15, 2021
Member
Landed in ac73d58 |
Flarna pushed a commit
that referenced
this pull request
Mar 15, 2021
PR-URL: #37743 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Ian Sutherland <ian@iansutherland.ca> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Mar 16, 2021
PR-URL: #37743 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Ian Sutherland <ian@iansutherland.ca> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
danielleadams pushed a commit
that referenced
this pull request
Mar 16, 2021
PR-URL: #37743 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Ian Sutherland <ian@iansutherland.ca> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed updating the
--helpoutput when removing experimental language from docs.