Skip to content

doc: add hints to http.request() options - #37745

Closed
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:add/hints-option
Closed

doc: add hints to http.request() options#37745
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:add/hints-option

Conversation

@lpinca

Copy link
Copy Markdown
Member

Add documentation for the hints option.

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Mar 13, 2021

@cjihrigcjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the linter is happy.

@PoojaDurgadPoojaDurgad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 15, 2021
lpinca added a commit that referenced this pull request Mar 15, 2021
PR-URL: #37745
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@lpinca

Copy link
Copy Markdown
MemberAuthor

Landed in 58166ae.

@lpincalpinca closed this Mar 15, 2021
@lpinca
lpinca deleted the add/hints-option branch March 15, 2021 20:16
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
PR-URL: #37745
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Mar 16, 2021
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
PR-URL: #37745
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37745
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.httpIssues or PRs related to the http subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@lpinca@Trott@cjihrig@marsonya@Flarna@RaisinTen@nodejs-github-bot@PoojaDurgad