Uh oh!
There was an error while loading. Please reload this page.
perf: add toJSON to performance class - #37771
Closed
yashLadha wants to merge 1 commit into
Closed
Conversation
jasnell
commented
Mar 16, 2021
Member
This should include a test |
targos
reviewed
Mar 16, 2021
Uh oh!
There was an error while loading. Please reload this page.
yashLadha
commented
Mar 16, 2021
ContributorAuthor
Yes will be adding it. |
yashLadhaforce-pushed
the
add_to_json_performance
branch
2 times, most recently
from
March 17, 2021 00:47
551aa74 to
5647f64CompareyashLadha
commented
Mar 17, 2021
ContributorAuthor
Added test @jasnell |
yashLadhaforce-pushed
the
add_to_json_performance
branch
4 times, most recently
from
March 17, 2021 01:49
a439e79 to
93ca72eCompareUh oh!
There was an error while loading. Please reload this page.
targos
reviewed
Mar 20, 2021
Uh oh!
There was an error while loading. Please reload this page.
yashLadhaforce-pushed
the
add_to_json_performance
branch
2 times, most recently
from
March 23, 2021 06:33
27a066c to
73e6da2Comparetargos
reviewed
Mar 23, 2021
Uh oh!
There was an error while loading. Please reload this page.
targos
reviewed
Mar 23, 2021
Uh oh!
There was an error while loading. Please reload this page.
Added toJSON method to the InternalPerformance class as per the convention followed in other performance classes and per the spec: https://www.w3.org/TR/hr-time/#tojson-methodFixes: nodejs#37623
yashLadhaforce-pushed
the
add_to_json_performance
branch
from
March 23, 2021 10:46
73e6da2 to
6c99cc7Comparejasnell
approved these changes
Apr 28, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Apr 30, 2021
Collaborator
Collaborator
jasnell
commented
Apr 30, 2021
Member
Landed in 93f0b4d |
jasnell pushed a commit
that referenced
this pull request
Apr 30, 2021
Added toJSON method to the InternalPerformance class as per the convention followed in other performance classes and per the spec: https://www.w3.org/TR/hr-time/#tojson-methodFixes: #37623 PR-URL: #37771Fixes: #37623 Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
May 3, 2021
Added toJSON method to the InternalPerformance class as per the convention followed in other performance classes and per the spec: https://www.w3.org/TR/hr-time/#tojson-methodFixes: #37623 PR-URL: #37771Fixes: #37623 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added toJSON method to the InternalPerformance class as per the
convention followed in other performance classes and per the spec:
https://www.w3.org/TR/hr-time/#tojson-method
Fixes: #37623