Skip to content

test: remove skip for fixed test-benchmark-fs - #37803

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:rm-fixed-skip
Mar 21, 2021
Merged

test: remove skip for fixed test-benchmark-fs#37803
Trott merged 1 commit into
nodejs:masterfrom
Trott:rm-fixed-skip

Conversation

@Trott

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 19, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@jasnelljasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Mar 19, 2021
PR-URL: nodejs#37803
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Trott merged commit baa9e65 into nodejs:masterMar 21, 2021
@Trott

Copy link
Copy Markdown
MemberAuthor

Landed in baa9e65

@Trott
Trott deleted the rm-fixed-skip branch March 21, 2021 15:26
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
PR-URL: #37803
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ruyadornoruyadorno mentioned this pull request Mar 30, 2021
targos pushed a commit that referenced this pull request May 1, 2021
PR-URL: #37803
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@nodejs-github-bot@jasnell@lpinca@targos@aduh95@marsonya