Skip to content

doc: add examples for WHATWG URL objects - #37822

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-url-examples
Closed

doc: add examples for WHATWG URL objects#37822
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-url-examples

Conversation

@jasnell

Copy link
Copy Markdown
Member

Refs: #25099 (comment)

Signed-off-by: James M Snell jasnell@gmail.com

Signed-off-by: James M Snell <jasnell@gmail.com>
@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Mar 19, 2021

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell

Copy link
Copy Markdown
MemberAuthor

Landed in 0932e90

@jasnelljasnell closed this Mar 22, 2021
jasnell added a commit that referenced this pull request Mar 22, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #37822
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #37822
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@ruyadornoruyadorno mentioned this pull request Mar 30, 2021
targos pushed a commit that referenced this pull request May 1, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #37822
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.urlIssues and PRs related to the legacy built-in url module.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jasnell@MylesBorins@addaleax@RaisinTen@nodejs-github-bot