Skip to content

doc: fix "the the" typo in README.md of cjs-module-lexer - #37895

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
peZhmanParsaee:doc-cjs-module-lexer-readme-typo
Mar 30, 2021
Merged

doc: fix "the the" typo in README.md of cjs-module-lexer#37895
aduh95 merged 1 commit into
nodejs:masterfrom
peZhmanParsaee:doc-cjs-module-lexer-readme-typo

Conversation

@peZhmanParsaee

@peZhmanParsaeepeZhmanParsaee commented Mar 24, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 24, 2021
@peZhmanParsaeepeZhmanParsaee changed the title fix "the the" typo in README.md of cjs-module-lexerdoc: fix "the the" typo in README.md of cjs-module-lexerMar 24, 2021
@aduh95

aduh95 commented Mar 24, 2021

Copy link
Copy Markdown
Contributor

/cc @guybedford

aduh95
aduh95 requested changes Mar 25, 2021
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change needs to be accepted upstream first (at https://github.com/guybedford/cjs-module-lexer) before it can land here.

@peZhmanParsaeepeZhmanParsaee mentioned this pull request Mar 25, 2021
Closed
@peZhmanParsaee

peZhmanParsaee commented Mar 26, 2021

Copy link
Copy Markdown
ContributorAuthor

This change needs to be accepted upstream first (at https://github.com/guybedford/cjs-module-lexer) before it can land here.

Hi @aduh95 , changes was applied on cjs-module-lexer repository. Would you reconsider your review? Tnx

@RaisinTen

RaisinTen commented Mar 26, 2021

Copy link
Copy Markdown
Member

@peZhmanParsaee We tend not to make changes to the parts in deps as these are updated with a PR when a new release of the dependency is available. You may check out #37712 to get an idea of how it has been done for cjs-module-lexer.

@aduh95

aduh95 commented Mar 26, 2021

Copy link
Copy Markdown
Contributor

Thanks a lot for taking the time to send the PR upstream. Guy has indicated in nodejs/cjs-module-lexer#48 (comment) that there's likely no upcoming release in the near future, so I suppose it is fine to land this here before it's officially released upstream. I'll try to take care of this early next week.

@peZhmanParsaee

peZhmanParsaee commented Mar 27, 2021

Copy link
Copy Markdown
ContributorAuthor

@aduh95

Thanks a lot dude
Your help is much appreciated and has given much positive energy to me :)

@peZhmanParsaee@aduh95
deps: cjs-module-lexer: cherry-pick 22093e765f
d7b8638
Original commit message:
fix "the the" typo in README.md file
Refs: nodejs/cjs-module-lexer@22093e7
PR-URL: nodejs#37895
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@aduh95
aduh95force-pushed the doc-cjs-module-lexer-readme-typo branch from 45dc755 to d7b8638CompareMarch 30, 2021 08:15
@aduh95
aduh95 merged commit d7b8638 into nodejs:masterMar 30, 2021
@aduh95

aduh95 commented Mar 30, 2021

Copy link
Copy Markdown
Contributor

Landed in d7b8638. Thanks for your contribution :)

MylesBorins pushed a commit that referenced this pull request Apr 4, 2021
@peZhmanParsaee@MylesBorins
deps: cjs-module-lexer: cherry-pick 22093e765f
913ec56
Original commit message:
fix "the the" typo in README.md file
Refs: nodejs/cjs-module-lexer@22093e7
PR-URL: #37895
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Apr 4, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes
@marsonyamarsonyamarsonya approved these changes
@HarshithaKPHarshithaKPHarshithaKP approved these changes
+1 more reviewer
@PoojaDurgadPoojaDurgadPoojaDurgad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@peZhmanParsaee@aduh95@RaisinTen@marsonya@HarshithaKP@PoojaDurgad@targos@nodejs-github-bot