Uh oh!
There was an error while loading. Please reload this page.
[v14.x] deps: V8 parent ordering fix backport - #37973
Closed
guybedford wants to merge 2 commits into
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
guybedfordforce-pushed
the
v8-cycle-fix-backport-14
branch
2 times, most recently
from
March 30, 2021 11:52
b74b214 to
3537fffCompareguybedfordforce-pushed
the
v8-cycle-fix-backport-14
branch
from
March 30, 2021 12:21
3537fff to
16edc5cCompare
This comment has been minimized.
This comment has been minimized.
guybedfordforce-pushed
the
v8-cycle-fix-backport-14
branch
from
March 30, 2021 15:36
16edc5c to
3c8169aCompare
This comment has been minimized.
This comment has been minimized.
guybedfordforce-pushed
the
v8-cycle-fix-backport-14
branch
from
March 30, 2021 17:29
3c8169a to
3625f1eCompare
This comment has been minimized.
This comment has been minimized.
guybedfordforce-pushed
the
v8-cycle-fix-backport-14
branch
from
March 30, 2021 18:27
3625f1e to
e15bf80CompareCollaborator
richardlau
approved these changes
Mar 31, 2021
Member
There was a problem hiding this comment.
Comment above says this should be incremented for each non-official patch, so probably each commit in this PR should bump the version up by one.
guybedfordforce-pushed
the
v8-cycle-fix-backport-14
branch
from
March 31, 2021 21:54
e15bf80 to
1a12e2fCompareguybedfordforce-pushed
the
v8-cycle-fix-backport-14
branch
from
April 1, 2021 18:02
1a12e2f to
3940d74Compare[torque] Move SourceTextModule flags definitions to Torque Refs: v8/v8@5f90cfd PR-URL: nodejs#37973 Reviewed-By: Richard Lau <rlau@redhat.com>
[top-level-await] Implement the new post-order requirement for async subgraphs Refs: v8/v8@f19142e PR-URL: nodejs#37864 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
guybedfordforce-pushed
the
v8-cycle-fix-backport-14
branch
from
April 8, 2021 14:33
3940d74 to
04da72fComparenodejs-github-bot
commented
Apr 8, 2021
Collaborator
guybedford added a commit
that referenced
this pull request
Apr 14, 2021
[torque] Move SourceTextModule flags definitions to Torque Refs: v8/v8@5f90cfd PR-URL: #37973 Reviewed-By: Richard Lau <rlau@redhat.com>
guybedford added a commit
that referenced
this pull request
Apr 14, 2021
[top-level-await] Implement the new post-order requirement for async subgraphs Refs: v8/v8@f19142e PR-URL: #37864 Backport-PR-URL: #37973 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
guybedford
commented
Apr 14, 2021
ContributorAuthor
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #37864 for 14.x. Getting this v8 patch to land cleanly required also porting v8/v8@5f90cfd which I've included as a separate commit in this PR.
This would be a very useful backport to ensure that between Node.js 14 and up, top-level await execution ordering semantics will always be well-defined and to specification.