Uh oh!
There was an error while loading. Please reload this page.
doc: add unref for input in readline - #38019
Conversation
5921b8f to
a5fe4a9Compare
RaisinTen
left a comment
There was a problem hiding this comment.
Thanks for making the PR. :)
Could you please address this review comment from a previous PR attempt to fix the related issue: #36458 (comment)?
I'm not sure this warrants its own section. Seems like it should go in the section of whatever call might result in requiring the
unref()call. It would be good to incorporate it into an existing section, I think.
nit: I think the commit message should say Fixes instead of Ref (but that can be fixed while landing).
AnupamaP
commented
Apr 1, 2021
@RaisinTen - Thanks for the review!
I did incorporate the edits into an existing section instead of making a new section i.e. |
RaisinTen
commented
Apr 1, 2021
The wait on the readable stream can also be ended by these calls: readable.destroy();readable.pause();readable.unshift(null);Should we also document these here? |
@RaisinTen Sure, we could do it in both places (readable and readline). Do you think it makes sense to add the following in the
|
Uh oh!
There was an error while loading. Please reload this page.
aduh95
commented
Apr 1, 2021
FWIW I don't think it's necessary: I think it's irrelevant to a user trying to interface with |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
PR-URL: nodejs#38019Fixes: nodejs#36154 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
aduh95
commented
Apr 3, 2021
Landed in 7980d7c |
Fixes: #36154