Uh oh!
There was an error while loading. Please reload this page.
test: fix flaky test-net-timeout - #38060
Closed
Trott wants to merge 1 commit into
Closed
Conversation
The check for an 800ms window makesw assumptions about a setTimeout() not running late etc. Remove it. Refs: nodejs#34289
Trott
commented
Apr 3, 2021
MemberAuthor
lpinca
approved these changes
Apr 3, 2021
juanarbol
approved these changes
Apr 3, 2021
cjihrig
approved these changes
Apr 3, 2021
nodejs-github-bot
commented
Apr 6, 2021
Collaborator
jasnell
approved these changes
Apr 6, 2021
nodejs-github-bot
commented
Apr 6, 2021
Collaborator
jasnell
commented
Apr 6, 2021
Member
Landed in 8b05e32 |
jasnell pushed a commit
that referenced
this pull request
Apr 6, 2021
The check for an 800ms window makesw assumptions about a setTimeout() not running late etc. Remove it. Refs: #34289 PR-URL: #38060 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
May 1, 2021
The check for an 800ms window makesw assumptions about a setTimeout() not running late etc. Remove it. Refs: #34289 PR-URL: #38060 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check for an 800ms window makes assumptions about a setTimeout()
not running late etc. Remove it.
Refs: #34289