Uh oh!
There was an error while loading. Please reload this page.
Add pseudo random number generator info to randomUUID - #38074
Merged
Conversation
ContributorAuthor
alternatively we can say "The UUID is generated using a cryptographically strong pseudo random number generator." as in the case of javadoc of randomUUID java method https://docs.oracle.com/javase/7/docs/api/java/util/UUID.html#randomUUID() |
jasnell
commented
Apr 6, 2021
Member
I'd remove the word "strong" to be honest. While it may be clear to those who are very familiar with pseudo-random number generators, I'd suspect that it's fairly meaningless to most developers. "The UUID is generated using a cryptographic pseudo-random number generator" would be just fine I think. |
Trott
approved these changes
Apr 11, 2021
Trott
reviewed
Apr 11, 2021
Uh oh!
There was an error while loading. Please reload this page.
Trott
approved these changes
Apr 11, 2021
Trottforce-pushed
the
docs-improve-randomUUID
branch
from
April 11, 2021 17:47
75650f2 to
051743cCompareTrott
approved these changes
Apr 11, 2021
PR-URL: nodejs#38074 Refs: nodejs#36729 Reviewed-By: Rich Trott <rtrott@gmail.com>
Trottforce-pushed
the
docs-improve-randomUUID
branch
from
April 11, 2021 20:40
051743c to
993a1daCompareTrott
commented
Apr 11, 2021
Member
Landed in 993a1da |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, 😊 !
As far as I understand, recently added function
crypto.randomUUIDis cryptographically strong. I think it's better to mention it in the docs.ref: #36729