Skip to content

doc: update buffer.constants.MAX_LENGTH - #38109

Closed
Ayase-252 wants to merge 4 commits into
nodejs:masterfrom
Ayase-252:fix/38093
Closed

doc: update buffer.constants.MAX_LENGTH#38109
Ayase-252 wants to merge 4 commits into
nodejs:masterfrom
Ayase-252:fix/38093

Conversation

@Ayase-252

@Ayase-252Ayase-252 commented Apr 6, 2021

Copy link
Copy Markdown
Member

This PR

  1. updates buffer.constants.MAX_LENGTH for different Node.js versions in 64-bit platform;
  2. adds a link to v8::TypedArray::kMaxLength as an informative note.

Fixes: #38093

@nodejs-github-botnodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Apr 6, 2021
RaisinTen
RaisinTen reviewed Apr 6, 2021
View reviewed changes
Comment threaddoc/api/buffer.md Outdated
aduh95
aduh95 reviewed Apr 6, 2021
View reviewed changes
Comment threaddoc/api/buffer.md Outdated
Comment threaddoc/api/buffer.md Outdated
@Ayase-252

Ayase-252 commented Apr 7, 2021•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@aduh95 I have documented changes in YAML headers. But I did not find a good way to incorprate the "initial" value 2 ** 31 - 1 into changes field, since it is not a change technically. Should I mention it in the main paragraph as the newest commit? Thanks.

aduh95
aduh95 approved these changes Apr 7, 2021
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with or without my suggestions.

Comment threaddoc/api/buffer.md Outdated
Comment threaddoc/api/buffer.md Outdated
Comment threaddoc/api/buffer.md Outdated
@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 8, 2021
@targos

targos commented Apr 11, 2021

Copy link
Copy Markdown
Member

@aduh95 added backport-requested-v14.x

Do you already know it won't land cleanly, or does it need to be adapted for the state of v14.x?

@aduh95

aduh95 commented Apr 11, 2021

Copy link
Copy Markdown
Contributor

Do you already know it won't land cleanly, or does it need to be adapted for the state of v14.x?

@targos the value is different in v15.x and v14.x, I believe a manual backport is necessary to adjust the value on the v14.x branch. Maybe a dont-land label is more appropriate? In any case, this should not be backported as is.

jasnell pushed a commit that referenced this pull request Apr 12, 2021
@Ayase-252@jasnell
doc: update buffer.constants.MAX_LENGTH
756d2e4
Fixes: #38093
PR-URL: #38109
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Apr 12, 2021

Copy link
Copy Markdown
Member

Landed in 756d2e4

@jasnelljasnell closed this Apr 12, 2021
@Ayase-252
Ayase-252 deleted the fix/38093 branch April 13, 2021 14:26
@juanarboljuanarbol mentioned this pull request Apr 13, 2021
Closed
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
@Ayase-252@BethGriggs
doc: update buffer.constants.MAX_LENGTH
fa2b2b7
Fixes: #38093
PR-URL: #38109
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Apr 16, 2021
Merged
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 20, 2021
@Ayase-252@juanarbol
doc: update buffer.constants.MAX_LENGTH
c25d394
Fixes: nodejs#38093
PR-URL: nodejs#38109
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Backport-PR-URL: nodejs#38232
targos pushed a commit that referenced this pull request Apr 24, 2021
@Ayase-252@targos
doc: update buffer.constants.MAX_LENGTH
9930b6b
Fixes: #38093
PR-URL: #38109
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Backport-PR-URL: #38232
@targostargos added backported-to-v14.x and removed backport-requested-v14.x author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 25, 2021
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@aduh95aduh95aduh95 approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

bufferIssues and PRs related to the buffer subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

buffer: buffer.constants.MAX_LENGTH is larger than expected

6 participants

@Ayase-252@targos@aduh95@jasnell@RaisinTen@nodejs-github-bot