Uh oh!
There was an error while loading. Please reload this page.
test: add undefined fatalException exit code test case - #38119
Closed
Linkgoron wants to merge 1 commit into
Closed
Conversation
Add a test that checks the exit code when _fatalException is undefined
nodejs-github-bot
commented
Apr 7, 2021
Collaborator
benjamingr
approved these changes
Apr 7, 2021
nodejs-github-bot
commented
Apr 7, 2021
Collaborator
jasnell
approved these changes
Apr 7, 2021
cjihrig
approved these changes
Apr 8, 2021
nodejs-github-bot
commented
Apr 12, 2021
Collaborator
jasnell
commented
Apr 12, 2021
Member
Landed in c8bbd83 |
jasnell pushed a commit
that referenced
this pull request
Apr 12, 2021
Add a test that checks the exit code when _fatalException is undefined PR-URL: #38119 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Apr 15, 2021
Add a test that checks the exit code when _fatalException is undefined PR-URL: #38119 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit
that referenced
this pull request
May 1, 2021
Add a test that checks the exit code when _fatalException is undefined PR-URL: #38119 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
danielleadams pushed a commit
that referenced
this pull request
May 8, 2021
Add a test that checks the exit code when _fatalException is undefined PR-URL: #38119 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test that checks the exit code when
_fatalExceptionisundefined. This change actually creates two tests - one for process exit code and one for worker exit codes.This case is extremely obscure, and probably unrealistic - but there's some explicit code in
node_errors.ccthat checks this case, so I've added a test for it.