Skip to content

tls: fix tlsSocket.setMaxSendFragment results in an abort - #38170

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
EladKeyshawn:eladkeyshawn-tls-setMaxSendFragment-abort
Apr 21, 2021
Merged

tls: fix tlsSocket.setMaxSendFragment results in an abort #38170
aduh95 merged 1 commit into
nodejs:masterfrom
EladKeyshawn:eladkeyshawn-tls-setMaxSendFragment-abort

Conversation

@EladKeyshawn

@EladKeyshawnEladKeyshawn commented Apr 9, 2021•
edited by aduh95
Loading

Copy link
Copy Markdown

Fixes: #38169

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem. labels Apr 9, 2021
aduh95
aduh95 reviewed Apr 9, 2021
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add tests?

Comment threadlib/_tls_wrap.js Outdated
@EladKeyshawn

EladKeyshawn commented Apr 9, 2021

Copy link
Copy Markdown
Author

Can you please add tests?
On it :)

aduh95
aduh95 reviewed Apr 9, 2021
View reviewed changes
Comment threadlib/_tls_wrap.js Outdated
Comment threadlib/_tls_wrap.js Outdated
Comment threadtest/parallel/test-tls-max-send-fragment.js Outdated
Comment threadtest/parallel/test-tls-max-send-fragment.js Outdated
aduh95
aduh95 reviewed Apr 10, 2021
View reviewed changes
Comment threadtest/parallel/test-tls-max-send-fragment.js Outdated
Comment threadtest/parallel/test-tls-max-send-fragment.js Outdated
Comment threadtest/parallel/test-tls-max-send-fragment.js Outdated
Comment threadtest/parallel/test-tls-max-send-fragment.js Outdated
Comment threadtest/parallel/test-tls-max-send-fragment.js Outdated
Comment threadtest/parallel/test-tls-max-send-fragment.js Outdated
@BridgeAR

BridgeAR commented Apr 10, 2021

Copy link
Copy Markdown
Member

@EladKeyshawn thanks a lot for addressing these issues! Since you open a couple PRs at the moment, would you mind reading about our commit message guidelines? They are referenced when opening a PR as well :-)

benjamingr
benjamingr approved these changes Apr 10, 2021
View reviewed changes

@benjamingrbenjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@benjamingr

benjamingr commented Apr 10, 2021

Copy link
Copy Markdown
Member

Please consider addressing Antoine's nits and taking Ruben's advice regarding the collaborator guidelines :]

@EladKeyshawn

EladKeyshawn commented Apr 10, 2021

Copy link
Copy Markdown
Author

Please consider addressing Antoine's nits and taking Ruben's advice regarding the collaborator guidelines :]

Thanks man!

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@EladKeyshawn

EladKeyshawn commented Apr 12, 2021

Copy link
Copy Markdown
Author

Can someone help me understand why the CI won't pass?

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@EladKeyshawnEladKeyshawn changed the title Suggest fix - tlsSocket.setMaxSendFragment results in an abort tls: fix tlsSocket.setMaxSendFragment results in an abort Apr 15, 2021
@nodejs-github-bot

nodejs-github-bot commented Apr 18, 2021•
edited by RaisinTen
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37551/ ✅

@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 18, 2021
@EladKeyshawn

EladKeyshawn commented Apr 20, 2021

Copy link
Copy Markdown
Author

@benjamingr Hey is this waiting for something?

@benjamingr

benjamingr commented Apr 20, 2021

Copy link
Copy Markdown
Member

@ronag I think this can land :)

@Ayase-252Ayase-252 mentioned this pull request Apr 21, 2021
Closed
@eladkishon@aduh95
tls: fix tlsSocket.setMaxSendFragment abort
6e3f985
PR-URL: nodejs#38170Fixes: nodejs#38169
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95
aduh95force-pushed the eladkeyshawn-tls-setMaxSendFragment-abort branch from 6a269bd to 6e3f985CompareApril 21, 2021 21:18
@aduh95

aduh95 commented Apr 21, 2021

Copy link
Copy Markdown
Contributor

Landed in 6e3f985

@aduh95
aduh95 merged commit 6e3f985 into nodejs:masterApr 21, 2021
@EladKeyshawn
EladKeyshawn deleted the eladkeyshawn-tls-setMaxSendFragment-abort branch April 22, 2021 06:08
targos pushed a commit that referenced this pull request Apr 29, 2021
@eladkishon@targos
tls: fix tlsSocket.setMaxSendFragment abort
f6745e9
PR-URL: #38170Fixes: #38169
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request May 3, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 left review comments
@jasnelljasnelljasnell approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.tlsIssues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tlsSocket.setMaxSendFragment results in an abort

10 participants

@EladKeyshawn@BridgeAR@benjamingr@nodejs-github-bot@aduh95@jasnell@lpinca@targos@RaisinTen@eladkishon