Skip to content

docs: add command flag to import.meta.resolve - #38171

Closed
iguessitsokay wants to merge 3 commits into
nodejs:masterfrom
iguessitsokay:patch-1
Closed

docs: add command flag to import.meta.resolve#38171
iguessitsokay wants to merge 3 commits into
nodejs:masterfrom
iguessitsokay:patch-1

Conversation

@iguessitsokay

Copy link
Copy Markdown
Contributor

import.meta.resolve is only available under --experimental-import-meta-resolve cli flag.

Source:

if(experimentalImportMetaResolve)

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 9, 2021

@marsonyamarsonya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint fix

Comment threaddoc/api/esm.md Outdated
thanks @marsonya
Co-authored-by: akhil marsonya <16393876+marsonya@users.noreply.github.com>
Comment threaddoc/api/esm.md Outdated
thanks @RaisinTen
Co-authored-by: Darshan Sen <raisinten@gmail.com>
@RaisinTen

Copy link
Copy Markdown
Member

nit: docs -> doc in the commit message (could be fixed while landing)

@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 11, 2021
jasnell pushed a commit that referenced this pull request Apr 12, 2021
import.meta.resolve is only available under
--experimental-import-meta-resolve cli flag.
Source:
https://github.com/nodejs/node/blob/e46c680bf2b211bbd52cf959ca17ee98c7f657f5/lib/internal/modules/esm/translators.js#L132
PR-URL: #38171
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

Copy link
Copy Markdown
Member

Landed in eee2c33

@jasnelljasnell closed this Apr 12, 2021
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
import.meta.resolve is only available under
--experimental-import-meta-resolve cli flag.
Source:
https://github.com/nodejs/node/blob/e46c680bf2b211bbd52cf959ca17ee98c7f657f5/lib/internal/modules/esm/translators.js#L132
PR-URL: #38171
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
import.meta.resolve is only available under
--experimental-import-meta-resolve cli flag.
Source:
https://github.com/nodejs/node/blob/e46c680bf2b211bbd52cf959ca17ee98c7f657f5/lib/internal/modules/esm/translators.js#L132
PR-URL: #38171
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
danielleadams pushed a commit that referenced this pull request May 8, 2021
import.meta.resolve is only available under
--experimental-import-meta-resolve cli flag.
Source:
https://github.com/nodejs/node/blob/e46c680bf2b211bbd52cf959ca17ee98c7f657f5/lib/internal/modules/esm/translators.js#L132
PR-URL: #38171
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@iguessitsokay@RaisinTen@jasnell@marsonya@nodejs-github-bot