Skip to content

tls: fix session and keylog add listener segfault - #38180

Closed
Linkgoron wants to merge 3 commits into
nodejs:masterfrom
Linkgoron:tls-fix-call-after-destroy
Closed

tls: fix session and keylog add listener segfault#38180
Linkgoron wants to merge 3 commits into
nodejs:masterfrom
Linkgoron:tls-fix-call-after-destroy

Conversation

@Linkgoron

@LinkgoronLinkgoron commented Apr 9, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Fix an issue where adding a session or keylog listener on a tlsSocket after it was destroyed causes a segfault.

fixes: #38133
fixes: #38135

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem. labels Apr 9, 2021
@Linkgoron
Linkgoronforce-pushed the tls-fix-call-after-destroy branch 3 times, most recently from 80f37a5 to 68d7662CompareApril 9, 2021 23:18
@Linkgoron
tls: fix session and keylog add listener segfault
581c0be
Fix an issue where adding a session or keylog listener on a tlsSocket
after it was destroyed caused a segfault.
fixes: nodejs#38133fixes: nodejs#38135
@Linkgoron
Linkgoronforce-pushed the tls-fix-call-after-destroy branch from 68d7662 to 581c0beCompareApril 9, 2021 23:18
@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37351/

@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37352/

lpinca
lpinca reviewed Apr 10, 2021
View reviewed changes
Comment threadtest/parallel/test-tls-tlswrap-segfault-2.js Outdated
Comment threadtest/parallel/test-tls-tlswrap-segfault-2.js Outdated
@nodejs-github-bot

nodejs-github-bot commented Apr 10, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37359/

@LinkgoronLinkgoron added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 10, 2021
@jasnell

jasnell commented Apr 12, 2021

Copy link
Copy Markdown
Member

Landed in 3da003c

@jasnelljasnell closed this Apr 12, 2021
jasnell pushed a commit that referenced this pull request Apr 12, 2021
@Linkgoron@jasnell
tls: fix session and keylog add listener segfault
3da003c
Fix an issue where adding a session or keylog listener on a tlsSocket
after it was destroyed caused a segfault.
fixes: #38133fixes: #38135
PR-URL: #38180Fixes: #38133Fixes: #38135
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
@Linkgoron@BethGriggs
tls: fix session and keylog add listener segfault
868da60
Fix an issue where adding a session or keylog listener on a tlsSocket
after it was destroyed caused a segfault.
fixes: #38133fixes: #38135
PR-URL: #38180Fixes: #38133Fixes: #38135
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Apr 16, 2021
Merged
targos pushed a commit that referenced this pull request May 30, 2021
@Linkgoron@targos
tls: fix session and keylog add listener segfault
4ba0659
Fix an issue where adding a session or keylog listener on a tlsSocket
after it was destroyed caused a segfault.
fixes: #38133fixes: #38135
PR-URL: #38180Fixes: #38133Fixes: #38135
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@Linkgoron@targos
tls: fix session and keylog add listener segfault
607aa9a
Fix an issue where adding a session or keylog listener on a tlsSocket
after it was destroyed caused a segfault.
fixes: #38133fixes: #38135
PR-URL: #38180Fixes: #38133Fixes: #38135
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@Linkgoron@targos
tls: fix session and keylog add listener segfault
661e980
Fix an issue where adding a session or keylog listener on a tlsSocket
after it was destroyed caused a segfault.
fixes: #38133fixes: #38135
PR-URL: #38180Fixes: #38133Fixes: #38135
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.tlsIssues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TLSSocket.prependOnceListener('session') results in an abort TLSSocket.prependOnceListener('keylog') results in a segmentation fault

5 participants

@Linkgoron@nodejs-github-bot@jasnell@lpinca@zyscoder