Skip to content

lib/querystring: Add JSDoc Types - #38185

Closed
Skn0tt wants to merge 8 commits into
nodejs:masterfrom
Skn0tt:querystring-jsdoc-types
Closed

lib/querystring: Add JSDoc Types#38185
Skn0tt wants to merge 8 commits into
nodejs:masterfrom
Skn0tt:querystring-jsdoc-types

Conversation

@Skn0tt

@Skn0ttSkn0tt commented Apr 10, 2021

Copy link
Copy Markdown
Contributor

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. querystring Issues and PRs related to the built-in querystring module. labels Apr 10, 2021
@Skn0ttSkn0tt mentioned this pull request Apr 10, 2021
Closed
bmeck
bmeck reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/internal/querystring.js Outdated
bmeck
bmeck reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/internal/querystring.js Outdated
bmeck
bmeck reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/internal/querystring.js Outdated
bmeck
bmeck reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
bmeck
bmeck reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
bmeck
bmeck reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
bmeck
bmeck reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
bmeck
bmeck reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
bmeck
bmeck reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
bmeck
bmeck reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
VoltrexKeyva
VoltrexKeyva reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
VoltrexKeyva
VoltrexKeyva reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
VoltrexKeyva
VoltrexKeyva reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
VoltrexKeyva
VoltrexKeyva reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
VoltrexKeyva
VoltrexKeyva reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
VoltrexKeyva
VoltrexKeyva reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
VoltrexKeyva
VoltrexKeyva reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
VoltrexKeyva
VoltrexKeyva reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
VoltrexKeyva
VoltrexKeyva reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
VoltrexKeyva
VoltrexKeyva reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
VoltrexKeyva
VoltrexKeyva reviewed Apr 10, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
bmeckand others added 2 commits April 10, 2021 20:12
@bmeck@VoltrexKeyva
linter
514ed2a
Co-authored-by: Voltrex <62040526+VoltrexMaster@users.noreply.github.com>
@bmeck@VoltrexKeyva
use bigint primitive form not object wrapped form
4b4742a
Co-authored-by: Voltrex <62040526+VoltrexMaster@users.noreply.github.com>
bmeck
bmeck reviewed Apr 11, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
VoltrexKeyva
VoltrexKeyva reviewed Apr 11, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
bmeck
bmeck reviewed Apr 11, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
VoltrexKeyva
VoltrexKeyva reviewed Apr 11, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
@bmeck@VoltrexKeyva
nits
c5d49fb
Co-authored-by: Voltrex <62040526+VoltrexMaster@users.noreply.github.com>
VoltrexKeyva
VoltrexKeyva reviewed Apr 11, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
VoltrexKeyva
VoltrexKeyva reviewed Apr 11, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
VoltrexKeyva
VoltrexKeyva reviewed Apr 11, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
@bmeck@VoltrexKeyva
lint
d63d5f3
Co-authored-by: Voltrex <62040526+VoltrexMaster@users.noreply.github.com>
targos
targos reviewed Apr 11, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
targos
targos reviewed Apr 11, 2021
View reviewed changes
Comment threadlib/querystring.js Outdated
bmeckand others added 2 commits April 13, 2021 08:38
@bmeck@targos
style
c5bbc9a
Co-authored-by: Michaël Zasso <targos@protonmail.com>
@targos@bmeck
Update lib/querystring.js
a7bd3e4
Co-authored-by: Bradley Farias <bradley.meck@gmail.com>
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Apr 16, 2021•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37503/ 💚

targos pushed a commit that referenced this pull request Apr 18, 2021
@Skn0tt@targos
typings: add JSDoc Types to lib/querystring
8acfe5c
PR-URL: #38185
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos

targos commented Apr 18, 2021

Copy link
Copy Markdown
Member

Landed in 8acfe5c

@targostargos closed this Apr 18, 2021
@BethGriggsBethGriggs mentioned this pull request Apr 20, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Skn0tt@targos
typings: add JSDoc Types to lib/querystring
599434a
PR-URL: #38185
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@danielleadamsdanielleadams mentioned this pull request May 3, 2021
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
@Skn0tt@danielleadams
typings: add JSDoc Types to lib/querystring
546a28f
PR-URL: #38185
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes
+2 more reviewers
@bmeckbmeckbmeck left review comments
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.querystringIssues and PRs related to the built-in querystring module.typings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Skn0tt@nodejs-github-bot@targos@bmeck@VoltrexKeyva