Uh oh!
There was an error while loading. Please reload this page.
typings: add JSDoc typings for http - #38191
Closed
VoltrexKeyva wants to merge 1 commit into
Closed
Conversation
Added JSDoc typings for the http lib.
bmeck
approved these changes
Apr 13, 2021
bmeck
left a comment
Member
There was a problem hiding this comment.
LGTM, definitely want to do this file iteratively for things like the handlers to not make it too hard to read in PR review
nodejs-github-bot
commented
Apr 14, 2021
Collaborator
nodejs-github-bot
commented
Apr 14, 2021
Collaborator
nodejs-github-bot
commented
Apr 15, 2021
Collaborator
targos
approved these changes
Apr 16, 2021
targos pushed a commit
that referenced
this pull request
Apr 16, 2021
PR-URL: #38191 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
commented
Apr 16, 2021
Member
Landed in d3162da |
targos pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #38191 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
danielleadams pushed a commit
that referenced
this pull request
May 8, 2021
PR-URL: #38191 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added JSDoc typings for the http lib.