Uh oh!
There was an error while loading. Please reload this page.
test: skip fs.watch() test on IBMi - #38192
Merged
Merged
Conversation
Trott
commented
Apr 11, 2021
MemberAuthor
IBMi CI on master to show it fails: https://ci.nodejs.org/job/node-test-commit-ibmi/333/ IBMi CI on this PR: https://ci.nodejs.org/job/node-test-commit-ibmi/334/ |
Trott
commented
Apr 11, 2021
MemberAuthor
Fast-track because this will cause node-daily-master to fail? |
Trott
commented
Apr 11, 2021
MemberAuthor
@nodejs/testing @nodejs/platform-ibmi |
nodejs-github-bot
commented
Apr 11, 2021
Collaborator
cjihrig
approved these changes
Apr 11, 2021
richardlau
approved these changes
Apr 11, 2021
Trott
commented
Apr 11, 2021
MemberAuthor
CI is good and this has enough approvals. We just need one more 👍 on the fast-track request in #38192 (comment). |
targos
approved these changes
Apr 11, 2021
We've added pummel tests to CI, so we need to add a skip for IBMi for the fs.watch() test there as we have for all the fs.watch() tests elsewhere. PR-URL: nodejs#38192 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Trott
commented
Apr 11, 2021
MemberAuthor
Landed in 95ca351 |
targos pushed a commit
that referenced
this pull request
May 1, 2021
We've added pummel tests to CI, so we need to add a skip for IBMi for the fs.watch() test there as we have for all the fs.watch() tests elsewhere. PR-URL: #38192 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
danielleadams pushed a commit
that referenced
this pull request
May 8, 2021
We've added pummel tests to CI, so we need to add a skip for IBMi for the fs.watch() test there as we have for all the fs.watch() tests elsewhere. PR-URL: #38192 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've added pummel tests to CI, so we need to add a skip for IBMi for
the fs.watch() test there as we have for all the fs.watch() tests
elsewhere.