Uh oh!
There was an error while loading. Please reload this page.
bootstrap: freeze more intrinsics - #38217
Conversation
ExE-Boss
left a comment
There was a problem hiding this comment.
These exist on primordials:
node/lib/internal/per_context/primordials.js
Lines 214 to 219 in 13c931a
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ExE-Boss
left a comment
There was a problem hiding this comment.
You forgot to add these to the const { ... } = primordials block.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
aduh95
commented
Apr 14, 2021
Thanks for the reminder, I didn't forget, I'm waiting for #38215 to land before putting work into this :) |
guybedford
left a comment
There was a problem hiding this comment.
Thanks for filling these in!
nodejs-github-bot
commented
Apr 19, 2021
nodejs-github-bot
commented
Apr 19, 2021
PR-URL: nodejs#38217 Reviewed-By: Guy Bedford <guybedford@gmail.com>
aduh95
commented
Apr 21, 2021
Landed in 7264dbd |
PR-URL: #38217 Reviewed-By: Guy Bedford <guybedford@gmail.com>
Several intrinsics were missing, and the comments were referencing an outdated version of ECMAScript spec.
Blockedon#37263,#38211, and#38215.