Skip to content

doc: Update BUILDING.md for Apple Silicon - #38227

Closed
AshCripps wants to merge 1 commit into
nodejs:masterfrom
AshCripps:update-building-md
Closed

doc: Update BUILDING.md for Apple Silicon#38227
AshCripps wants to merge 1 commit into
nodejs:masterfrom
AshCripps:update-building-md

Conversation

@AshCripps

Copy link
Copy Markdown
Member

Update BUILDING.md to be correct for Apple Silicon for 16.x

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Apr 13, 2021
@aduh95aduh95 added arm Issues and PRs related to the ARM architecture. macos Issues and PRs related to the macOS platform / OSX. labels Apr 13, 2021
@aduh95

Copy link
Copy Markdown
Contributor

Does this need to be backported to v14.x and v15.x?

@AshCripps

AshCripps commented Apr 13, 2021

Copy link
Copy Markdown
MemberAuthor

Does this need to be backported to v14.x and v15.x?

No we dont release for Apple silicon on those lines

@BethGriggsBethGriggs added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 13, 2021
@BethGriggs

Copy link
Copy Markdown
Member

Fast-track?

Comment threadBUILDING.md Outdated
AshCripps pushed a commit that referenced this pull request Apr 14, 2021
PR-URL: #38227
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@AshCripps

Copy link
Copy Markdown
MemberAuthor

Landed in 98c2067

@AshCripps
AshCripps deleted the update-building-md branch April 15, 2021 10:21
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
PR-URL: #38227
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

armIssues and PRs related to the ARM architecture.buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.macosIssues and PRs related to the macOS platform / OSX.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@AshCripps@aduh95@BethGriggs@Trott@targos@gengjiawen@richardlau@nodejs-github-bot