Skip to content

tls: validate ticket keys buffer - #38308

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:tls-ticket-keys
Apr 23, 2021
Merged

tls: validate ticket keys buffer#38308
aduh95 merged 1 commit into
nodejs:masterfrom
aduh95:tls-ticket-keys

Conversation

@aduh95

@aduh95aduh95 commented Apr 20, 2021

Copy link
Copy Markdown
Contributor

Fixes: #38305

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. tls Issues and PRs related to the tls subsystem. labels Apr 20, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTenRaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 20, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
lpinca
lpinca approved these changes Apr 20, 2021
View reviewed changes
Comment threadtest/parallel/test-tls-ticket-invalid-arg.js Outdated
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Apr 20, 2021•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37587/ 💚

@aduh95
tls: validate ticket keys buffer
e151e90
Fixes: nodejs#38305
PR-URL: nodejs#38308
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95

aduh95 commented Apr 23, 2021

Copy link
Copy Markdown
ContributorAuthor

Landed in e151e90

@aduh95
aduh95 merged commit e151e90 into nodejs:masterApr 23, 2021
@aduh95
aduh95 deleted the tls-ticket-keys branch April 23, 2021 11:19
targos pushed a commit that referenced this pull request Apr 29, 2021
@aduh95@targos
tls: validate ticket keys buffer
5b393d9
Fixes: #38305
PR-URL: #38308
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request May 3, 2021
Merged
targos pushed a commit that referenced this pull request May 30, 2021
@aduh95@targos
tls: validate ticket keys buffer
1b7d392
Fixes: #38305
PR-URL: #38308
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@aduh95@targos
tls: validate ticket keys buffer
0388603
Fixes: #38305
PR-URL: #38308
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@aduh95@targos
tls: validate ticket keys buffer
f6e4dbb
Fixes: #38305
PR-URL: #38308
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.tlsIssues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tlsServer.setTicketKeys results in an abort

5 participants

@aduh95@nodejs-github-bot@jasnell@lpinca@RaisinTen