Skip to content

src: fix abort in pbkdf2 - #38354

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:src-fix-crash-formatting
Closed

src: fix abort in pbkdf2#38354
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:src-fix-crash-formatting

Conversation

@tniessen

@tniessentniessen commented Apr 22, 2021

Copy link
Copy Markdown
Member

This should be fixed in more places where double formatting is an issue.

cc @panva

Fixes: #38341

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 22, 2021
@tniessentniessen mentioned this pull request Apr 22, 2021
Closed
@tniessen
tniessenforce-pushed the src-fix-crash-formatting branch from 35e415d to 9037ec9CompareApril 22, 2021 14:58
@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37611/

@panvapanva mentioned this pull request Apr 22, 2021
Closed
@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37614/

@tniessentniessen removed the needs-ci PRs that need a full CI run. label Apr 22, 2021
@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37617/

@nodejs-github-bot

nodejs-github-bot commented Apr 23, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37628/

@panvapanva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 23, 2021
@nodejs-github-bot

nodejs-github-bot commented Apr 23, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37631/

panva pushed a commit that referenced this pull request Apr 24, 2021
@tniessen@panva
src: fix abort in pbkdf2
81d7e80
Fixes: #38341
PR-URL: #38354
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@panva

panva commented Apr 24, 2021

Copy link
Copy Markdown
Member

Landed in 81d7e80

@panvapanva closed this Apr 24, 2021
targos pushed a commit that referenced this pull request Apr 29, 2021
@tniessen@targos
src: fix abort in pbkdf2
e3538bb
Fixes: #38341
PR-URL: #38354
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targostargos mentioned this pull request May 3, 2021
Merged
@tniessen
tniessen deleted the src-fix-crash-formatting branch October 7, 2021 16:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panvapanvapanva approved these changes
@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crypto.pbkdf2Sync results in an abort

7 participants

@tniessen@nodejs-github-bot@panva@jasnell@addaleax@cjihrig@targos