Skip to content

test: move slower tests into pummel and skip on slow devices - #38395

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:move-some-pummels
Apr 27, 2021
Merged

test: move slower tests into pummel and skip on slow devices#38395
Trott merged 1 commit into
nodejs:masterfrom
Trott:move-some-pummels

Conversation

@Trott

Copy link
Copy Markdown
Member

Move slower tests to pummel and skip on Raspberry Pi devices in CI.

Refs: #34289 (comment)

@Trott
Trott requested a review from targosApril 25, 2021 04:36
@nodejs-github-bot

This comment has been minimized.

@targostargos added the test Issues and PRs related to the tests. label Apr 25, 2021
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@Trott

Copy link
Copy Markdown
MemberAuthor

Fast-track to help our backed-up arm-fanned CI jobs?

@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 26, 2021
@TrottTrott removed the fast-track PRs that do not need to wait for 48 hours to land. label Apr 27, 2021
Move slower tests to pummel and skip on Raspberry Pi devices in CI.
Refs: nodejs#34289 (comment)
PR-URL: nodejs#38395
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@Trott
Trottforce-pushed the move-some-pummels branch from 06498fb to 7f56307CompareApril 27, 2021 04:21
@Trott

Copy link
Copy Markdown
MemberAuthor

Landed in 7f56307

@Trott
Trott merged commit 7f56307 into nodejs:masterApr 27, 2021
@Trott
Trott deleted the move-some-pummels branch April 27, 2021 04:22
targos pushed a commit that referenced this pull request Apr 29, 2021
Move slower tests to pummel and skip on Raspberry Pi devices in CI.
Refs: #34289 (comment)
PR-URL: #38395
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@targostargos mentioned this pull request May 3, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@nodejs-github-bot@panva@jasnell@addaleax@targos@cjihrig