Uh oh!
There was an error while loading. Please reload this page.
test: move abort test from pummel to abort directory - #38396
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
targos
approved these changes
Apr 25, 2021
nodejs-github-bot
commented
Apr 25, 2021
Collaborator
addaleax
approved these changes
Apr 25, 2021
cjihrig
approved these changes
Apr 25, 2021
nodejs-github-bot
commented
Apr 25, 2021
Collaborator
jasnell
approved these changes
Apr 25, 2021
nodejs-github-bot
commented
Apr 26, 2021
Collaborator
test-abort-fatal-error is not resource intensive and would be better in the abort directory than the pummel directory. PR-URL: nodejs#38396 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
commented
Apr 27, 2021
MemberAuthor
Landed in 6f296b5 |
targos pushed a commit
that referenced
this pull request
Apr 29, 2021
test-abort-fatal-error is not resource intensive and would be better in the abort directory than the pummel directory. PR-URL: #38396 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
May 30, 2021
test-abort-fatal-error is not resource intensive and would be better in the abort directory than the pummel directory. PR-URL: #38396 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Jun 5, 2021
test-abort-fatal-error is not resource intensive and would be better in the abort directory than the pummel directory. PR-URL: #38396 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Jun 5, 2021
test-abort-fatal-error is not resource intensive and would be better in the abort directory than the pummel directory. PR-URL: #38396 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Jun 11, 2021
test-abort-fatal-error is not resource intensive and would be better in the abort directory than the pummel directory. PR-URL: #38396 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-abort-fatal-error is not resource intensive and would be better in
the abort directory than the pummel directory.